Fix linespacing #1008
Merged
Fix linespacing #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
scaleandoneSvgPerLineparameters of therenderAbcfunction, the distance between the lines is not scaled accordantly.e.g.: A scale factor of 0.3 results in following rendering:
I would expect that the distance is also scaled down like this:
Using a scalefactor greater then 1 will at some point cut the svg, omitting part of the score
I think the height of the div should be scaled down. The height of the SVG will be changed by the transform but the height of the sourounding div is like it wasn't scaled.
Not sure if I found the right position but it worked for my textcase…