Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils: replace isPlainObject with a robuster implementation #22

Closed
wants to merge 1 commit into from

Conversation

ocavue
Copy link
Contributor

@ocavue ocavue commented Feb 1, 2024

Copy the code from the NPM package is-plain-obj to replace our current isPlainObject implementation. Closes #21.

I choose to copy code instead of adding it as a dependency because of the following reasons:

  1. is-plain-obj is an ESM-only package, while noble is an ESM-CJS dual package.
  2. @noble/ciphers is designed as zero-dependency.

@maccman
Copy link

maccman commented Feb 8, 2024

@paulmillr Just bumping this one. I suspect you'll want to merge it.

@paulmillr
Copy link
Owner

Solved in 2e49a16. It's only used internally, so it was simplified.

@paulmillr paulmillr closed this Feb 9, 2024
@paulmillr
Copy link
Owner

0.5.0 is out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

isPlainObject returns false incorrectly
3 participants