feat: add /rg command (ripgrep for /add files)
#540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…files. # Aider chat conversation: USER: I ran this command: rg '/run <command>' -B 8 -A 5 -H -n -- README.md And got this output: README.md-121-## In-chat commands README.md-122- README.md-123-Aider supports commands from within the chat, which all start with `/`. Here are some of the most useful in-chat commands: README.md-124- README.md-125-* `/add <file>`: Add matching files to the chat session. README.md-126-* `/drop <file>`: Remove matching files from the chat session. README.md-127-* `/undo`: Undo the last git commit if it was done by aider. README.md-128-* `/diff`: Display the diff of the last aider commit. README.md:129:* `/run <command>`: Run a shell command and optionally add the output to the chat. README.md-130-* `/voice`: Speak to aider to [request code changes with your voice](https://aider.chat/docs/voice.html). README.md-131-* `/help`: Show help about all commands. README.md-132- README.md-133-See the [full command docs](https://aider.chat/docs/commands.html) for more information. README.md-134- ASSISTANT: It seems you've provided the output of a `ripgrep` command that was run on a `README.md` file, which is not currently in the list of *read-write* files in this session. If you would like to make changes to the `README.md` file based on this output, please add it to the chat so I can assist you with making the necessary edits. USER: Add `/rg` documentation to the README.md and docs/commands.md files ASSISTANT: Here are the diffs to add the `/rg` documentation to the `README.md` and `docs/commands.md` files: ```diff --- README.md +++ README.md @@ ... @@ * `/undo`: Undo the last git commit if it was done by aider. * `/diff`: Display the diff of the last aider commit. +* `/rg <pattern>`: Run ripgrep with the given pattern and add the matching files to the chat. * `/run <command>`: Run a shell command and optionally add the output to the chat. * `/voice`: Speak to aider to [request code changes with your voice](https://aider.chat/docs/voice.html). * `/help`: Show help about all commands. @@ ... @@ ``` ```diff --- docs/commands.md +++ docs/commands.md @@ ... @@ - `/diff`: Display the diff of the last aider commit - `/commit <message>`: Commit edits to the repo made outside the chat (commit message optional) +- `/rg <pattern>`: Run ripgrep with the given pattern and add the matching files to the chat - `/git <command>`: Run a git command @@ ... @@ ``` These diffs will add the new `/rg` command documentation to the respective sections in both files.
aleclarson
changed the title
/rg command/rg command (ripgrep for /add files)
|
This is nice. Would it be possible to make the Also, one thing you might want to check out in the interim is fzf shell integration. This way, you can type |
avi-cenna
reviewed
May 6, 2024
| @@ -495,6 +495,34 @@ def cmd_run(self, args, add_on_nonzero_exit=False): | |||
| ) | |||
| return msg | |||
|
|
|||
| # Add cmd_rg for calling ripgrep with -l and the user-provided arguments. Then call cmd_add with the returned file names. | |||
| def cmd_rg(self, args): | |||
There was a problem hiding this comment.
Does this library have unit/integration tests for commands? If not, I would paste a screenshot of this working locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Using this command requires ripgrep installed on your machine.
How it works
It calls
rgthrough a subprocess with the-lflag to return a list of filenames. These filenames are then fed into the/addcommand. Anything you pass after/rgis forwarded to the ripgrep tool.