Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ability to ignore elements #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wooolfgang
Copy link

@wooolfgang wooolfgang commented Apr 2, 2020

Hi @patleeman , first off - thank you for the great work! We're using this module for our web-app editor, and it works well.

One of the features we need for our comment section is to disallow certain elements such as headers + dividers (hr). In this pull request, I added a simple option (ignore = []) that will allow the ignoring of elements during auto-formatting.

Let me know your thoughts or feedback/issues with the submitted code.
Thanks!

@ivictbor
Copy link

ivictbor commented Jan 26, 2021

@wooolfgang I just wanted to create a same PR ;)
Thanks a lot.

@patleeman will you merge and release? Are you active on a project or should we fork?

I love the plugin but now we face an annoying case when you type:

The variable_name is a snakecase, which means you type_underscore

Which makes

The variable name is a snakecase, which means you type underscore

Or lets just fix this regexp https://github.com/patleeman/quill-markdown-shortcuts/blob/master/src/index.js#L118

so it should include whitespace (or be at the beginning of the line) before first underscore. And same logic with last

Same issue with bold

We fixed the issue in our repo https://github.com/devforth/quill-markdown-shortcuts (npm i -S @devforth/quill-markdown-shortcuts)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants