fix(app): making distinction between technically possible points and …

…points to tell the user about (#3148) * fix(app): making distinction between technically possible points and points to tell the user about * chore(platforms): updating holonym sidebar language
passportxyz · Dec 17, 2024 · bdb0b56 · bdb0b56
1 parent 69a9496
commit bdb0b56
Show file tree

Hide file tree

Showing 8 changed files with 41 additions and 9 deletions.
diff --git a/app/__test-fixtures__/contextTestHelpers.tsx b/app/__test-fixtures__/contextTestHelpers.tsx
@@ -151,6 +151,7 @@ export const scorerContext = {
       connectMessage: "Verify amount",
       isEVM: true,
       possiblePoints: 7.4399999999999995,
+      displayPossiblePoints: 7.4399999999999995,
       earnedPoints: 0,
     },
     {
@@ -161,6 +162,7 @@ export const scorerContext = {
       connectMessage: "Connect Account",
       isEVM: true,
       possiblePoints: 12.93,
+      displayPossiblePoints: 12.93,
       earnedPoints: 0,
     },
     {
@@ -170,6 +172,7 @@ export const scorerContext = {
       description: "Connect your existing Twitter account to verify.",
       connectMessage: "Connect Account",
       possiblePoints: 3.63,
+      displayPossiblePoints: 3.63,
       earnedPoints: 3.63,
     },
     {
@@ -179,6 +182,7 @@ export const scorerContext = {
       description: "Connect your existing Discord account to verify.",
       connectMessage: "Connect Account",
       possiblePoints: 0.689,
+      displayPossiblePoints: 0.689,
       earnedPoints: 0,
     },
     {
@@ -188,6 +192,7 @@ export const scorerContext = {
       description: "Connect your existing Google Account to verify",
       connectMessage: "Connect Account",
       possiblePoints: 2.25,
+      displayPossiblePoints: 2.25,
       earnedPoints: 1,
     },
   ],

diff --git a/app/__tests__/components/CardList.test.tsx b/app/__tests__/components/CardList.test.tsx
@@ -55,6 +55,7 @@ let categoryProps: CategoryProps = {
         name: "Github",
         platform: "Github",
         possiblePoints: 7.0600000000000005,
+        displayPossiblePoints: 7.0600000000000005,
         website: "https://github.com",
       },
       {
@@ -65,6 +66,7 @@ let categoryProps: CategoryProps = {
         name: "Google",
         platform: "Google",
         possiblePoints: 0.525,
+        displayPossiblePoints: 0.525,
         website: "https://www.google.com/",
       },
       {
@@ -75,6 +77,7 @@ let categoryProps: CategoryProps = {
         name: "Discord",
         platform: "Discord",
         possiblePoints: 0.516,
+        displayPossiblePoints: 0.516,
         website: "https://discord.com/",
       },
     ],
@@ -147,6 +150,7 @@ describe("<CardList />", () => {
             description: "ETH",
             connectMessage: "ETH",
             possiblePoints: 10,
+            displayPossiblePoints: 10,
             earnedPoints: 7,
           }}
           onOpen={mockOnOpen}
@@ -187,6 +191,7 @@ describe("<CardList />", () => {
           connectMessage: "Verify",
           isEVM: true,
           possiblePoints: 100,
+          displayPossiblePoints: 100,
           earnedPoints: 100,
         },
       ] as PlatformScoreSpec[],
@@ -241,6 +246,7 @@ describe("show/hide tests", () => {
       scoredPlatforms: [
         {
           possiblePoints: 10,
+          displayPossiblePoints: 10,
           earnedPoints: 0,
           platform: "TestPlatform" as PLATFORM_ID,
           name: "Test Platform",
@@ -285,6 +291,7 @@ describe("show/hide tests", () => {
       scoredPlatforms: [
         {
           possiblePoints: 10,
+          displayPossiblePoints: 10,
           earnedPoints: 5,
           platform: "TestPlatform" as PLATFORM_ID,
           name: "Test Platform",
@@ -340,6 +347,7 @@ describe("show/hide tests", () => {
       scoredPlatforms: [
         {
           possiblePoints: 10,
+          displayPossiblePoints: 10,
           earnedPoints: 0,
           platform: "NFT" as PLATFORM_ID,
           name: "NFT",
@@ -379,6 +387,7 @@ describe("show/hide tests", () => {
       scoredPlatforms: [
         {
           possiblePoints: 10,
+          displayPossiblePoints: 10,
           earnedPoints: 10,
           platform: "AllowList",
           name: "Allow List Platform",
@@ -421,6 +430,7 @@ describe("show/hide tests", () => {
       scoredPlatforms: [
         {
           possiblePoints: 10,
+          displayPossiblePoints: 10,
           earnedPoints: 0,
           platform: "AllowList",
           name: "Allow List Platform",
@@ -456,6 +466,7 @@ describe("show/hide tests", () => {
       scoredPlatforms: [
         {
           possiblePoints: 10,
+          displayPossiblePoints: 10,
           earnedPoints: 2,
           ...platforms["GtcStaking"].PlatformDetails,
         },
@@ -484,6 +495,7 @@ describe("show/hide tests", () => {
       scoredPlatforms: [
         {
           possiblePoints: 10,
+          displayPossiblePoints: 10,
           earnedPoints: 2,
           ...platforms["GtcStaking"].PlatformDetails,
         },
@@ -506,6 +518,7 @@ describe("show/hide tests", () => {
       scoredPlatforms: [
         {
           possiblePoints: 10,
+          displayPossiblePoints: 10,
           earnedPoints: 2,
           ...platforms["GtcStaking"].PlatformDetails,
         },
@@ -528,6 +541,7 @@ describe("show/hide tests", () => {
       scoredPlatforms: [
         {
           possiblePoints: 0,
+          displayPossiblePoints: 10,
           earnedPoints: 0,
           ...platforms["GtcStaking"].PlatformDetails,
         },

diff --git a/app/components/CardList.tsx b/app/components/CardList.tsx
@@ -109,8 +109,8 @@ export const CardList = ({ className, isLoading = false, initialOpen = true }: C
   );
 
   const sortedPlatforms = [
-    ...unverified.sort((a, b) => b.possiblePoints - a.possiblePoints),
-    ...verified.sort((a, b) => b.possiblePoints - b.earnedPoints - (a.possiblePoints - a.earnedPoints)),
+    ...unverified.sort((a, b) => b.displayPossiblePoints - a.displayPossiblePoints),
+    ...verified.sort((a, b) => b.displayPossiblePoints - b.earnedPoints - (a.displayPossiblePoints - a.earnedPoints)),
   ];
 
   const groupedPlatforms: {

diff --git a/app/components/PlatformCard.tsx b/app/components/PlatformCard.tsx
@@ -71,7 +71,7 @@ const DefaultStamp = ({ idx, platform, className, onClick, variant }: StampProps
             )}
             <div className={`text-right`}>
               <h1 data-testid="available-points" className="text-2xl text-color-2">
-                {+Math.max(platform.possiblePoints - platform.earnedPoints, 0).toFixed(1)}
+                {+Math.max(platform.displayPossiblePoints - platform.earnedPoints, 0).toFixed(1)}
               </h1>
               <p className="text-xs">Available Points</p>
             </div>
@@ -169,7 +169,7 @@ const VerifiedStamp = ({ idx, platform, daysUntilExpiration, className, onClick
           <div className="text-2xl font-bold">{+platform.earnedPoints.toFixed(1)}</div>
           <ProgressBar
             pointsGained={platform.earnedPoints}
-            pointsAvailable={Math.max(platform.possiblePoints - platform.earnedPoints, 0)}
+            pointsAvailable={Math.max(platform.displayPossiblePoints - platform.earnedPoints, 0)}
             isSlim={true}
           />
         </div>
@@ -253,7 +253,7 @@ const ExpiredStamp = ({ idx, platform, daysUntilExpiration, className, onClick }
           <div className="text-2xl font-bold">{+platform.earnedPoints.toFixed(1)}</div>
           <ProgressBar
             pointsGained={platform.earnedPoints}
-            pointsAvailable={Math.max(platform.possiblePoints - platform.earnedPoints, 0)}
+            pointsAvailable={Math.max(platform.displayPossiblePoints - platform.earnedPoints, 0)}
             isSlim={true}
           />
         </div>

diff --git a/app/components/PlatformDetails.tsx b/app/components/PlatformDetails.tsx
@@ -139,7 +139,7 @@ export const PlatformDetails = ({
   const hasStamps = platformPassportData && !!platformPassportData.length;
 
   const earnedPoints = currentPlatformScoreSpec?.earnedPoints || 0;
-  const possiblePoints = currentPlatformScoreSpec?.possiblePoints || 0;
+  const possiblePoints = currentPlatformScoreSpec?.displayPossiblePoints || 0;
 
   const pointsGained = +earnedPoints.toFixed(1);
   const pointsAvailable = +Math.max(possiblePoints - earnedPoints, 0).toFixed(1);

diff --git a/app/context/scorerContext.tsx b/app/context/scorerContext.tsx
@@ -32,6 +32,9 @@ export type StampScores = {
 
 export type PlatformScoreSpec = PlatformSpec & {
   possiblePoints: number;
+  // Possible points that we want to tell the user
+  // about (i.e. excluding deprecated providers)
+  displayPossiblePoints: number;
   earnedPoints: number;
 };
 
@@ -214,6 +217,10 @@ export const ScorerContextProvider = ({ children }: { children: any }) => {
       const scoredPlatforms = [...platforms.keys()].map((platformId) => {
         const providers = platformProviders[platformId];
         const possiblePoints = providers.reduce(
+          (acc, { name }) => acc + (parseFloat(stampWeights[name] || "0") || 0),
+          0
+        );
+        const displayPossiblePoints = providers.reduce(
           (acc, { name, isDeprecated }) => acc + (isDeprecated ? 0 : parseFloat(stampWeights[name] || "0") || 0),
           0
         );
@@ -222,6 +229,7 @@ export const ScorerContextProvider = ({ children }: { children: any }) => {
         return {
           ...platformSpec,
           possiblePoints,
+          displayPossiblePoints,
           earnedPoints,
         };
       });
@@ -231,7 +239,9 @@ export const ScorerContextProvider = ({ children }: { children: any }) => {
 
   useEffect(() => {
     if (!stampScores || !stampWeights) {
-      setScoredPlatforms(platformSpecs.map((platform) => ({ ...platform, possiblePoints: 0, earnedPoints: 0 })));
+      setScoredPlatforms(
+        platformSpecs.map((platform) => ({ ...platform, possiblePoints: 0, earnedPoints: 0, displayPossiblePoints: 0 }))
+      );
       return;
     }
     calculatePlatformScore();

diff --git a/platforms/src/Holonym/App-Bindings.tsx b/platforms/src/Holonym/App-Bindings.tsx
@@ -18,7 +18,7 @@ export class HolonymPlatform implements Platform {
         </li>
         <li>
           Go to <Hyperlink href="https://holonym.id">Holonym's page</Hyperlink>, verify your ID by connecting your
-          wallet, and follow prompts to obtain the Government ID, ePassport or Phone Proofs
+          wallet, and follow prompts to obtain the Government ID, ePassport or Phone Proofs.
         </li>
         <li>After verification, mint the SBT to your wallet, then link it to your Passport by verifying it.</li>
       </ul>

diff --git a/platforms/src/Holonym/Providers-config.ts b/platforms/src/Holonym/Providers-config.ts
@@ -17,9 +17,12 @@ export const ProviderConfig: PlatformGroupSpec[] = [
     platformGroup: "Holonym KYC",
     providers: [
       { title: "Proven uniqueness using Holonym KYC with government ID or ePassport", name: "HolonymGovIdProvider" },
-      { title: "Proven uniqueness using Holonym Phone Verification", name: "HolonymPhone" },
     ],
   },
+  {
+    platformGroup: "Phone Number",
+    providers: [{ title: "Proven uniqueness using Holonym Phone Verification", name: "HolonymPhone" }],
+  },
 ];
 
 export const providers: Provider[] = [new HolonymGovIdProvider(), new HolonymPhone()];