Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Facebook Limited Login not working due to incorrect domain in JWT validation #9122

Merged
merged 5 commits into from May 16, 2024

Conversation

chriscborg
Copy link
Contributor

Pull Request

Issue

Add support for Facebook auth JWT token #9117

Closes: #9117

Approach

A JWT token validation implementation seems to be already in place, however the host needs to be changed from facebook.com to www.facebook.com as suggested by @SebC99, because the old host is returning error 301 which is not followed by the jwt-rsa package.

Tasks

  • Add changes to documentation (guides, repository pages, code comments)

Copy link

The branch release can only be set as base branch by members of @parse-community/core-maintainers.

Pull requests are usually opened against the default branch alpha, which is the working branch. Different repositories may have base branches with different names. If you are sure you need to open this pull request against a different branch, please ask someone from the team mentioned above.

@parse-github-assistant parse-github-assistant bot changed the base branch from release to alpha May 7, 2024 07:38
Copy link

Thanks for opening this pull request!

@chriscborg chriscborg changed the title fix: Changes facebook auth host to resolve JWT validation issue on e fix: Changes facebook auth host to resolve JWT validation issue on release May 7, 2024
@chriscborg chriscborg changed the title fix: Changes facebook auth host to resolve JWT validation issue on release fix: Changes facebook auth host to resolve JWT validation issue May 8, 2024
Copy link

codecov bot commented May 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.15%. Comparing base (f1469c6) to head (2d181fb).
Report is 9 commits behind head on alpha.

Additional details and impacted files
@@            Coverage Diff             @@
##            alpha    #9122      +/-   ##
==========================================
+ Coverage   94.13%   94.15%   +0.01%     
==========================================
  Files         186      186              
  Lines       14687    14724      +37     
==========================================
+ Hits        13826    13863      +37     
  Misses        861      861              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtrezza mtrezza changed the title fix: Changes facebook auth host to resolve JWT validation issue fix: Facebook Limited Login not workind due to incorrect domain in JWT validation May 16, 2024
@mtrezza
Copy link
Member

mtrezza commented May 16, 2024

@chriscborg would you please merge alpha or rebase? Unfortunately I can't do it since your PR is protected.

@mtrezza mtrezza changed the title fix: Facebook Limited Login not workind due to incorrect domain in JWT validation fix: Facebook Limited Login not working due to incorrect domain in JWT validation May 16, 2024
@mtrezza mtrezza merged commit 9d0bd2b into parse-community:alpha May 16, 2024
20 of 26 checks passed
parseplatformorg pushed a commit that referenced this pull request May 16, 2024
# [7.1.0-alpha.7](7.1.0-alpha.6...7.1.0-alpha.7) (2024-05-16)

### Bug Fixes

* Facebook Limited Login not working due to incorrect domain in JWT validation ([#9122](#9122)) ([9d0bd2b](9d0bd2b))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.1.0-alpha.7

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released-alpha Released as alpha version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Facebook auth JWT token
3 participants