feat: Ensure Database Password Security Check Covers All Possible URIs

spec/SecurityCheckGroups.spec.js

@@ -62,20 +62,36 @@ describe('Security Check Groups', () => {
  expect(group.checks().length).toBeGreaterThan(0);
  });
 
- it('checks succeed correctly', async () => {
+ it('checks succeed correctly with database adapter defined', async () => {
  const config = Config.get(Parse.applicationId);
  config.database.adapter._uri = 'protocol://user:[email protected]';
  const group = new CheckGroupDatabase();
  await group.run();
  expect(group.checks()[0].checkState()).toBe(CheckState.success);
  });
 
- it('checks fail correctly', async () => {
+ it('checks succeed correctly with databaseURI defined', async () => {
+ const config = Config.get(Parse.applicationId);
+ config.databaseURI = 'protocol://user:[email protected]';
+ const group = new CheckGroupDatabase();
+ await group.run();
+ expect(group.checks()[0].checkState()).toBe(CheckState.success);
+ });
+
+ it('checks fail correctly with database adapter defined', async () => {
  const config = Config.get(Parse.applicationId);
  config.database.adapter._uri = 'protocol://user:[email protected]';
  const group = new CheckGroupDatabase();
  await group.run();
  expect(group.checks()[0].checkState()).toBe(CheckState.fail);
  });
+
+ it('checks fail correctly with databaseURI defined', async () => {
+ const config = Config.get(Parse.applicationId);
+ config.databaseURI = 'protocol://user:[email protected]';
+ const group = new CheckGroupDatabase();
+ await group.run();
+ expect(group.checks()[0].checkState()).toBe(CheckState.fail);
+ });
  });
 });

src/Security/CheckGroups/CheckGroupDatabase.js

@@ -14,8 +14,18 @@
  }
  setChecks() {
  const config = Config.get(Parse.applicationId);
+ let databaseUrl;
  const databaseAdapter = config.database.adapter;
- const databaseUrl = databaseAdapter._uri;
+ if (databaseAdapter) {
+ // If database adapter is defined, use its URI
+ databaseUrl = databaseAdapter._uri;
+ } else if (config.databaseURI) {
+ // If database adapter is not defined, fallback to config.databaseURI
+ databaseUrl = config.databaseURI;
+ } else {
+ // Handle the case where neither database adapter nor databaseURI is defined
+ throw 1;
+ }
  return [
  new Check({
  title: 'Secure database password',