feat: make doc links dynamic #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The one file used by both sites will create a more consistent docs link experience.
|
mtrezza
approved these changes
Jun 12, 2023
There was a problem hiding this comment.
Looks good, can this be merged? Or should we wait for parse-community/parse-community.github.io#49 to be ready, just in case?
|
We do #49 first, and then add a script tag pointing to the |
|
Cool, this is good to merge |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the doc links are fixed. This can be changed by building them dynamically.
The file
js/linkscould be served either here or onparseplatform.org.Related: parse-community/parse-community.github.io#49
Closes #932