add type DATE #98
Open
add type DATE #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acalvoa
reviewed
May 16, 2019
src/earlgrey/core/ModelCore.java
Outdated
| @@ -217,6 +218,9 @@ else if(campo.getType().equals(String.class)){ | |||
| else if(campo.getType().equals(Timestamp.class)){ | |||
| campo.set(m, set.getString(llave)); | |||
| } | |||
| else if(campo.getType().equals(DATE.class)){ | |||
There was a problem hiding this comment.
Correct Sintax
if (Condition) {
// Code
} else if (Condition) {
// Code
} else {
// Code
}
acalvoa
reviewed
May 16, 2019
| this.pstm.setDATE(this.prepared_fields++, (DATE)prepare_fields.get(campo)); | ||
| } catch (SQLException e) { | ||
| // TODO Auto-generated catch block | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
Evitar el uso de print stacktrace y codigo try autogenerados
Gestionar el error de mejor forma.
acalvoa
reviewed
May 16, 2019
| else if(campo.getType().equals(DATE.class)){ | ||
| try { | ||
| this.pstm.setDATE(this.prepared_fields++, (DATE)prepare_fields.get(campo)); | ||
| } catch (SQLException e) { |
There was a problem hiding this comment.
Mismo caso, en este caso seria bueno informar al logger de earlgrey que ocurrio
added 3 commits
May 16, 2019 15:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Se añade tipo DATE