Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pallet-revive] Add tracing support (1/3) #7166

Merged
merged 33 commits into from
Jan 17, 2025
Merged

Conversation

pgherveou
Copy link
Contributor

@pgherveou pgherveou commented Jan 14, 2025

Add foundation for supporting call traces in pallet_revive

Follow up:

@pgherveou
Copy link
Contributor Author

/cmd prdoc --audience runtime_dev --bump minor

@pgherveou pgherveou added T7-smart_contracts This PR/Issue is related to smart contracts. R0-silent Changes should not be mentioned in any release notes labels Jan 14, 2025
@pgherveou pgherveou force-pushed the pg/add-tracing-support branch from 0ded99f to e07f355 Compare January 14, 2025 23:41
@pgherveou pgherveou changed the title [pallet-revive] Add tracing support [pallet-revive] Add tracing support 1/3 Jan 14, 2025
@pgherveou pgherveou changed the title [pallet-revive] Add tracing support 1/3 [pallet-revive] Add tracing support (1/3) Jan 14, 2025
@pgherveou pgherveou requested review from athei and xermicus January 15, 2025 13:28
Copy link
Member

@xermicus xermicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Base automatically changed from pg/replace-debug-trace to master January 15, 2025 18:11
substrate/frame/revive/src/lib.rs Outdated Show resolved Hide resolved
substrate/frame/revive/src/lib.rs Outdated Show resolved Hide resolved
substrate/frame/revive/src/lib.rs Outdated Show resolved Hide resolved
substrate/frame/revive/src/lib.rs Outdated Show resolved Hide resolved
substrate/frame/revive/src/debug.rs Outdated Show resolved Hide resolved
substrate/frame/revive/src/debug.rs Outdated Show resolved Hide resolved
substrate/frame/revive/src/debug.rs Outdated Show resolved Hide resolved
substrate/frame/revive/src/debug.rs Outdated Show resolved Hide resolved
@pgherveou pgherveou requested a review from athei January 17, 2025 10:15
substrate/frame/revive/src/tracing.rs Show resolved Hide resolved
substrate/frame/revive/src/lib.rs Outdated Show resolved Hide resolved
substrate/frame/revive/src/tracing.rs Outdated Show resolved Hide resolved
@pgherveou pgherveou enabled auto-merge January 17, 2025 13:20
Copy link
Member

@athei athei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just asking for some renames. This using wording is kind of confusing to me. Let's just call it trace because that is what it does.

substrate/frame/revive/src/tracing.rs Outdated Show resolved Hide resolved
substrate/frame/revive/src/tracing.rs Outdated Show resolved Hide resolved
substrate/frame/revive/src/tracing.rs Outdated Show resolved Hide resolved
Copy link
Member

@athei athei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

me gusta

@pgherveou pgherveou added this pull request to the merge queue Jan 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 17, 2025
@athei athei added this pull request to the merge queue Jan 17, 2025
@athei
Copy link
Member

athei commented Jan 17, 2025

Gotta love those random network errors inside the merge queue.

@athei athei removed this pull request from the merge queue due to a manual request Jan 17, 2025
@pgherveou pgherveou added this pull request to the merge queue Jan 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jan 17, 2025
@pgherveou pgherveou enabled auto-merge January 17, 2025 15:34
@pgherveou pgherveou disabled auto-merge January 17, 2025 16:50
@pgherveou pgherveou enabled auto-merge January 17, 2025 16:50
@pgherveou pgherveou added this pull request to the merge queue Jan 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 17, 2025
@athei athei added this pull request to the merge queue Jan 17, 2025
Merged via the queue into master with commit 7702fdd Jan 17, 2025
174 of 183 checks passed
@athei athei deleted the pg/add-tracing-support branch January 17, 2025 20:43
pgherveou added a commit that referenced this pull request Jan 17, 2025
Add foundation for supporting call traces in pallet_revive

Follow up:
- PR #7167 Add changes to eth-rpc to introduce debug endpoint that will
use pallet-revive tracing features
- PR #6727 Add new RPC to the client and implement tracing runtime API
that can capture traces on previous blocks

---------

Co-authored-by: Alexander Theißen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes T7-smart_contracts This PR/Issue is related to smart contracts.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants