Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/cmd swap omnibench #6769

Merged
merged 45 commits into from
Dec 9, 2024
Merged

/cmd swap omnibench #6769

merged 45 commits into from
Dec 9, 2024

Conversation

mordamax
Copy link
Contributor

@mordamax mordamax commented Dec 5, 2024 •
edited
Loading

  • change bench to default to old CLI
  • fix profile to production

mordamax and others added 30 commits November 8, 2024 13:16
@mordamax
trying to backport the old benches
f576493
@mordamax
Update cmd.py
88d29b6
@mordamax
Update cmd.py
bba2907
@mordamax
Update cmd.py
80ac471
@mordamax
Update cmd.py
43f122e
@mordamax
Update cmd.py
147c2e3
@mordamax
Update cmd.py
883cad6
@mordamax
[skip ci] add build log
c5e9dca
@mordamax
[skip ci] disable forklift add --locked
02ec4b0
@mordamax
Update cmd.py
7502ab1
@actions-user @mordamax
Update from mordamax running command 'bench-old --runtime westend --p…
2fb7616 
…allet pallet_balances --clean'
@actions-user @mordamax
Update from mordamax running command 'bench-old --runtime westend --p…
0286591 
…allet pallet_balances'
@mordamax
add machine test to old
3cd2295
@actions-user @mordamax
Update from mordamax running command 'bench --runtime westend --palle…
3f49f14 
…t pallet_balances'
@mordamax
".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…
66ae5ea 
…=westend --target_dir=polkadot --pallet=pallet_balances
@mordamax
".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…
bccd675 
…=westend --target_dir=polkadot --pallet=pallet_balances --machine=y
@mordamax
disable docker in docker
bde8830
@mordamax
move checkout earlier
fe65482
@mordamax
Update cmd.yml
96125fc
@mordamax
Update cmd.yml
a353557
@mordamax
add cache and remove forklift
70350bb
@mordamax
oldlinux
b63212f
@mordamax
cmd-bot-vm
1fc8f06
@mordamax
cmd-bot-vm - production
fb94590
@mordamax
cmd-bot old - production
f89a743
@actions-user
Update from mordamax running command 'bench-old --runtime westend --p…
7a756e8 
…allet pallet_balances'
@actions-user
Update from mordamax running command 'bench --runtime westend --palle…
f8b6ce3 
…t pallet_balances'
".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…
61ee3d5 
…=westend --target_dir=polkadot --pallet=pallet_balances
@mordamax
Merge branch 'master' into mak-cmd-backport-old-bench
2ed47dd
@mordamax
Update cmd.py
603b97f
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024

Command "bench-omni --runtime westend --pallet pallet_balances" has started 🚀 See logs here

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024

Command "bench-omni --runtime westend --pallet pallet_balances" has finished ✅ See logs here

Subweight results:
File Extrinsic Old New Change [%]
cumulus/pallets/collator-selection/src/weights.rs leave_intent - - ERROR
cumulus/pallets/collator-selection/src/weights.rs new_session - - ERROR
cumulus/pallets/collator-selection/src/weights.rs register_as_candidate - - ERROR
cumulus/pallets/collator-selection/src/weights.rs set_invulnerables - - ERROR
cumulus/pallets/collator-selection/src/weights.rs take_candidate_slot - - ERROR
cumulus/pallets/collator-selection/src/weights.rs update_bond - - ERROR
cumulus/parachains/runtimes/assets/asset-hub-rococo/src/weights/pallet_collator_selection.rs take_candidate_slot - - ERROR
cumulus/parachains/runtimes/assets/asset-hub-rococo/src/weights/pallet_collator_selection.rs update_bond - - ERROR
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_collator_selection.rs take_candidate_slot - - ERROR
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_collator_selection.rs update_bond - - ERROR
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/src/weights/pallet_collator_selection.rs take_candidate_slot - - ERROR
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/src/weights/pallet_collator_selection.rs update_bond - - ERROR
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-westend/src/weights/pallet_collator_selection.rs take_candidate_slot - - ERROR
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-westend/src/weights/pallet_collator_selection.rs update_bond - - ERROR
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_collator_selection.rs take_candidate_slot - - ERROR
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_collator_selection.rs update_bond - - ERROR
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_core_fellowship_ambassador_core.rs promote_fast - - ERROR
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_core_fellowship_fellowship_core.rs promote_fast - - ERROR
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_preimage.rs ensure_updated - - ERROR
cumulus/parachains/runtimes/people/people-rococo/src/weights/pallet_collator_selection.rs take_candidate_slot - - ERROR
cumulus/parachains/runtimes/people/people-rococo/src/weights/pallet_collator_selection.rs update_bond - - ERROR
cumulus/parachains/runtimes/people/people-westend/src/weights/pallet_collator_selection.rs take_candidate_slot - - ERROR
cumulus/parachains/runtimes/people/people-westend/src/weights/pallet_collator_selection.rs update_bond - - ERROR
polkadot/runtime/westend/src/weights/pallet_preimage.rs ensure_updated - - ERROR
substrate/frame/election-provider-support/src/weights.rs phragmen - - ERROR
substrate/frame/election-provider-support/src/weights.rs phragmms - - ERROR
polkadot/runtime/westend/src/weights/pallet_balances.rs burn_keep_alive 21.53us 28.16us +30.80
polkadot/runtime/westend/src/weights/pallet_balances.rs force_adjust_total_issuance 6.92us 8.87us +28.19
polkadot/runtime/westend/src/weights/pallet_balances.rs burn_allow_death 32.10us 41.03us +27.80
polkadot/runtime/westend/src/weights/pallet_balances.rs transfer_allow_death 176.67us 192.36us +8.88
polkadot/runtime/westend/src/weights/pallet_balances.rs transfer_all 175.02us 189.80us +8.44
polkadot/runtime/westend/src/weights/pallet_balances.rs transfer_keep_alive 166.72us 177.80us +6.65
Command output:

✅ Successful benchmarks of runtimes/pallets:
-- westend: ['pallet_balances']

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024

Command "bench --runtime westend --pallet pallet_balances" has failed ❌! See logs here

Command output:

✅ Successful benchmarks of runtimes/pallets:
-- westend: ['pallet_balances']

@mordamax
Copy link
Contributor Author

mordamax commented Dec 6, 2024

/cmd bench --runtime westend --pallet pallet_balances

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024

Command "bench --runtime westend --pallet pallet_balances" has started 🚀 See logs here

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024

Command "bench --runtime westend --pallet pallet_balances" has finished ✅ See logs here

Subweight results:
File Extrinsic Old New Change [%]
cumulus/pallets/collator-selection/src/weights.rs leave_intent - - ERROR
cumulus/pallets/collator-selection/src/weights.rs new_session - - ERROR
cumulus/pallets/collator-selection/src/weights.rs register_as_candidate - - ERROR
cumulus/pallets/collator-selection/src/weights.rs set_invulnerables - - ERROR
cumulus/pallets/collator-selection/src/weights.rs take_candidate_slot - - ERROR
cumulus/pallets/collator-selection/src/weights.rs update_bond - - ERROR
cumulus/parachains/runtimes/assets/asset-hub-rococo/src/weights/pallet_collator_selection.rs take_candidate_slot - - ERROR
cumulus/parachains/runtimes/assets/asset-hub-rococo/src/weights/pallet_collator_selection.rs update_bond - - ERROR
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_collator_selection.rs take_candidate_slot - - ERROR
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_collator_selection.rs update_bond - - ERROR
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/src/weights/pallet_collator_selection.rs take_candidate_slot - - ERROR
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/src/weights/pallet_collator_selection.rs update_bond - - ERROR
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-westend/src/weights/pallet_collator_selection.rs take_candidate_slot - - ERROR
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-westend/src/weights/pallet_collator_selection.rs update_bond - - ERROR
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_collator_selection.rs take_candidate_slot - - ERROR
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_collator_selection.rs update_bond - - ERROR
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_core_fellowship_ambassador_core.rs promote_fast - - ERROR
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_core_fellowship_fellowship_core.rs promote_fast - - ERROR
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_preimage.rs ensure_updated - - ERROR
cumulus/parachains/runtimes/people/people-rococo/src/weights/pallet_collator_selection.rs take_candidate_slot - - ERROR
cumulus/parachains/runtimes/people/people-rococo/src/weights/pallet_collator_selection.rs update_bond - - ERROR
cumulus/parachains/runtimes/people/people-westend/src/weights/pallet_collator_selection.rs take_candidate_slot - - ERROR
cumulus/parachains/runtimes/people/people-westend/src/weights/pallet_collator_selection.rs update_bond - - ERROR
polkadot/runtime/westend/src/weights/pallet_preimage.rs ensure_updated - - ERROR
substrate/frame/election-provider-support/src/weights.rs phragmen - - ERROR
substrate/frame/election-provider-support/src/weights.rs phragmms - - ERROR
Command output:

✅ Successful benchmarks of runtimes/pallets:
-- westend: ['pallet_balances']

@mordamax mordamax marked this pull request as ready for review December 8, 2024 21:23
@mordamax mordamax requested review from a team as code owners December 8, 2024 21:23
@mordamax mordamax added the R0-silent Changes should not be mentioned in any release notes label Dec 8, 2024
@mordamax mordamax enabled auto-merge December 9, 2024 11:20
bkchr
bkchr approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it called old package/bin?

@mordamax mordamax added this pull request to the merge queue Dec 9, 2024
@mordamax
Copy link
Contributor Author

mordamax commented Dec 9, 2024 •
edited
Loading

Why is it called old package/bin?

it was originally not intended to be merged, i named it just for temporary PR :)
but the meaning was old way of calling benchmarks (unlike we do with frame-omni-bencher), in reality package name is not old ))

Merged via the queue into master with commit 81b979a Dec 9, 2024
198 of 202 checks passed
@mordamax mordamax deleted the mak-cmd-swap-omnibench branch December 9, 2024 13:58
@mordamax mordamax changed the title Mak cmd swap omnibench /cmd swap omnibench Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvicsam alvicsam alvicsam approved these changes

@ggwpez ggwpez ggwpez approved these changes

@AndWeHaveAPlan AndWeHaveAPlan AndWeHaveAPlan approved these changes

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mordamax @bkchr @AndWeHaveAPlan @ggwpez @alvicsam @actions-user