Remove Deref implementation from CandidateHash and update affected co… #6763
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the Deref implementation from CandidateHash and updates all affected code to reflect this change. This resolves a specific issue where the use of Deref for CandidateHash was deemed inappropriate and could lead to potential misuse or unclear code semantics.
Issue Linked: Fixes #5224
Integration
Downstream projects relying on CandidateHash should note that the Deref implementation is no longer available. Instead, direct methods or traits should be used for accessing the inner hash value. No additional changes are required apart from adopting this updated interface.
Example:
Before:
let hash_value = candidate_hash.deref();
After:
let hash_value = candidate_hash.value();
Ensure that all usages of Deref for CandidateHash in downstream projects are updated to avoid compilation errors.
Review Notes
This PR includes the following changes:
Detailed implementation notes:
Removed the
Deref
implementation fromCandidateHash
.Refactored internal usages to align with the updated interface.
Updated tests across all affected modules to ensure compatibility.
My PR includes a detailed description as outlined above.