Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: update nightly in ci-unified to 2024-11-19 #6691

Merged
merged 4 commits into from
Nov 29, 2024
Merged

ci: update nightly in ci-unified to 2024-11-19 #6691

merged 4 commits into from
Nov 29, 2024

Conversation

alvicsam
Copy link
Contributor

@alvicsam alvicsam commented Nov 28, 2024 •
edited
Loading

@alvicsam alvicsam added the R0-silent Changes should not be mentioned in any release notes label Nov 28, 2024
@alvicsam alvicsam marked this pull request as ready for review November 29, 2024 09:07
@alvicsam alvicsam requested review from a team as code owners November 29, 2024 09:07
athei
athei reviewed Nov 29, 2024
View reviewed changes
Copy link
Member

@athei athei left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the toolchain in there as nightly or as the named toolchain? We need the names toolchain. Otherwise Rustup will still try to download it even though it matches the nightly version.

@alvicsam
Copy link
Contributor Author

@athei it has both names nightly-2024-11-19-x86_64-unknown-linux-gnu and nightly-x86_64-unknown-linux-gnu. (Can be seen here)

@athei
Copy link
Member

athei commented Nov 29, 2024

Okay thanks then it should work.

@athei athei enabled auto-merge November 29, 2024 09:44
@athei athei added this pull request to the merge queue Nov 29, 2024
Merged via the queue into master with commit 1dd21bc Nov 29, 2024
200 of 205 checks passed
@athei athei deleted the as-ci-upd-nightly branch November 29, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreiEres AndreiEres AndreiEres approved these changes

@lovelaced lovelaced lovelaced approved these changes

@AndWeHaveAPlan AndWeHaveAPlan AndWeHaveAPlan approved these changes

@EgorPopelyaev EgorPopelyaev EgorPopelyaev approved these changes

@athei athei athei approved these changes

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alvicsam @athei @EgorPopelyaev @AndWeHaveAPlan @lovelaced @AndreiEres