-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fatxpool
: proper handling of priorities when mempool is full
#6647
Draft
michalkucharczyk
wants to merge
23
commits into
master
Choose a base branch
from
mku-fatxpool-mempool-priorities-at-limits
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
fatxpool
: proper handling of priorities when mempool is full
#6647
michalkucharczyk
wants to merge
23
commits into
master
from
mku-fatxpool-mempool-priorities-at-limits
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalkucharczyk
force-pushed
the
mku-fatxpool-mempool-priorities-at-limits
branch
from
November 26, 2024 12:52
724c102
to
4338671
Compare
michalkucharczyk
force-pushed
the
mku-fatxpool-mempool-priorities-at-limits
branch
from
December 4, 2024 10:03
04ac71a
to
4f767e5
Compare
All GitHub workflows were cancelled due to failure one of the required jobs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Higher-priority transactions can now replace lower-priority transactions even when the internal tx_mem_pool is full.
Notes for reviewers:
at
block, but this is computationally expensive. To avoid additional validation overhead, I opted to use the priority obtained from runtime during submission to the view. This is the rationale behind introducing theSubmitOutcome
struct, which synchronously communicates transaction priority from the view to the pool. This results in a very brief window during which the transaction priority remains unknown - those transaction are taken into consideration while dropping takes place. In the future, if needed, we could update transaction priority using view revalidation results to keep this information fully up-to-date (as priority of transaction may change with chain-state evolution).remove_transaction_subtree
). To ensure complete removal, thePendingTxReplacement
struct was re-factored to more genericPendingPreInsertTask
(introduced infatxpool
: handling limits and priorities improvements #6405) which covers removal and submssion of transaction in the view which may be potentially created in the background. This is to ensure that removed transaction will not re-enter to the newly created view.Closes: #5809