Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable2409] Backport #6579 #6635

Merged
merged 4 commits into from
Nov 27, 2024
Merged

Conversation

paritytech-cmd-bot-polkadot-sdk[bot]

Backport #6579 into stable2409 from bkontur.

See the documentation on how to use this bot.

@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Nov 25, 2024
Copy link

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

Copy link
Contributor

@acatangiu acatangiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stable2409 pallet-xcm is still using log crate and not tracing crate. While this PR adds a few new tracing::* logs. Does this build, dependencies met, etc?

@bkontur
Copy link
Contributor

bkontur commented Nov 27, 2024

stable2409 pallet-xcm is still using log crate and not tracing crate. While this PR adds a few new tracing::* logs. Does this build, dependencies met, etc?

yes, everything works,
stable2409 pallet-xcm has already tracing backported sometime ago by 60f9909#diff-d8807ae7778f0cc0ad31a1231c6acb25bb9eee2733ee9ebe0e22dbe1852c5c40R18

@acatangiu acatangiu enabled auto-merge (squash) November 27, 2024 09:51
@EgorPopelyaev EgorPopelyaev merged commit 9fe2d73 into stable2409 Nov 27, 2024
39 of 44 checks passed
@EgorPopelyaev EgorPopelyaev deleted the backport-6579-to-stable2409 branch November 27, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A3-backport Pull request is already reviewed well in another branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants