Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate pallet-tx-pause to umbrella crate #6630

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

bennethxyz
Copy link

Part of #6504

@cla-bot-2021
Copy link

cla-bot-2021 bot commented Nov 24, 2024

User @bennethxyz, please sign the CLA here.

@bennethxyz bennethxyz marked this pull request as ready for review November 24, 2024 19:59
@bennethxyz bennethxyz requested a review from a team as a code owner November 24, 2024 19:59
use frame::{
prelude::frame_system,
runtime::{
prelude::{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preludes are meant to be imported as prelude::*.

Please read the instructions of the tracking issue as to how to do this migration more carefully.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kianenigma There are cases where only one item is needed in the prelude

@bennethxyz
Copy link
Author

I believe the recent changes follows the guidelines @re-gius

@re-gius re-gius added R0-silent Changes should not be mentioned in any release notes T1-FRAME This PR/Issue is related to core FRAME, the framework. labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants