Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrating pallet-xcm-benchmarks to V2 #6618

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Migrating pallet-xcm-benchmarks to V2 #6618

wants to merge 5 commits into from
+394 −258

Conversation

Krayt78
Copy link

@Krayt78 Krayt78 commented Nov 22, 2024

Description

Migrated pallet-xcm-benchmarks to benchmaking syntax V2
This is part of #6202

@Krayt78 Krayt78 requested a review from a team as a code owner November 22, 2024 22:46
@Krayt78 Krayt78 mentioned this pull request Nov 22, 2024
Open
44 tasks
shawntabrizi
shawntabrizi approved these changes Nov 24, 2024
View reviewed changes
Copy link
Member

@shawntabrizi shawntabrizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my review could def be more in depth, but i scrolled through the PR, and everything looks sensible.

@re-gius re-gius added R0-silent Changes should not be mentioned in any release notes T2-pallets This PR/Issue is related to a particular pallet. T12-benchmarks This PR/Issue is related to benchmarking and weights. labels Nov 27, 2024
@github-actions GitHub Actions
Copy link

Review required! Latest push from author must always be reviewed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@re-gius re-gius re-gius approved these changes

@shawntabrizi shawntabrizi Awaiting requested review from shawntabrizi

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes T2-pallets This PR/Issue is related to a particular pallet. T12-benchmarks This PR/Issue is related to benchmarking and weights.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Krayt78 @shawntabrizi @re-gius