Bump PolkaVM version #6533
Open
Bump PolkaVM version #6533
+2,443
−2,062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarkkojs
force-pushed
the
bump-polkavm-version
branch
from
cbe0284
to
f8ddde9
Compare
jarkkojs
force-pushed
the
bump-polkavm-version
branch
7 times, most recently
from
3e5bb53
to
626ada2
Compare
athei
reviewed
Nov 19, 2024
jarkkojs
force-pushed
the
bump-polkavm-version
branch
11 times, most recently
from
80a60ee
to
39c80c9
Compare
Signed-off-by: Jarkko Sakkinen <[email protected]>
jarkkojs
force-pushed
the
bump-polkavm-version
branch
from
39c80c9
to
f91a828
Compare
Signed-off-by: Jarkko Sakkinen <[email protected]>
|
BTW, please help me to interpret the CI errors... |
koute
reviewed
Nov 20, 2024
substrate/client/executor/common/src/runtime_blob/runtime_blob.rs
Outdated
Show resolved
Hide resolved
Signed-off-by: Jarkko Sakkinen <[email protected]>
…tats() Signed-off-by: Jarkko Sakkinen <[email protected]>
Signed-off-by: Jarkko Sakkinen <[email protected]>
Signed-off-by: Jarkko Sakkinen <[email protected]>
Signed-off-by: Jarkko Sakkinen <[email protected]>
|
I'm sure I missed something but did my best ;-) |
Signed-off-by: Jarkko Sakkinen <[email protected]>
|
2x oldlinux tests failing |
Signed-off-by: Jarkko Sakkinen <[email protected]>
Signed-off-by: Jarkko Sakkinen <[email protected]>
Signed-off-by: Jarkko Sakkinen <[email protected]>
2 tasks
athei
reviewed
Nov 22, 2024
substrate/client/executor/common/src/runtime_blob/runtime_blob.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexander Theißen <[email protected]>
Signed-off-by: Jarkko Sakkinen <[email protected]>
Signed-off-by: Jarkko Sakkinen <[email protected]>
Signed-off-by: Jarkko Sakkinen <[email protected]>
…stats() Signed-off-by: Jarkko Sakkinen <[email protected]>
koute
reviewed
Nov 25, 2024
Comment on lines
-46
to
-51
| let Some(method_index) = self.0.module().lookup_export(name) else { | ||
| return ( | ||
| Err(format!("cannot call into the runtime: export not found: '{name}'").into()), | ||
| None, | ||
| ); | ||
| }; |
There was a problem hiding this comment.
Still missing this piece of code.
([edit]Alex told you to get rid of the snippet with find, but that's actually the preferable way of doing this, so please restore it.[/edit])
There was a problem hiding this comment.
OK so then probably something else must be used than call_typed. Can you give advice on that?
There was a problem hiding this comment.
Other issues resolved except this as I'm not sure how to sort this out. Should prepare_call_untyped() be used?
Fixes based on Jan's review comment except method_index back because we don't know how to do it and what would be the use for it. Issue comments related to this are linked below. Link: paritytech#6533 (comment) Link: paritytech#6533 (comment) Reported-by: Jan Bujak <[email protected]> Signed-off-by: Jarkko Sakkinen <[email protected]>
Signed-off-by: Jarkko Sakkinen <[email protected]>
|
@athei ready for re-review |
Signed-off-by: Jarkko Sakkinen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to bump the PolkaVM version for https://github.com/paritytech/polkadot-sdk/tree/master/substrate/client/executor/polkavm, and thus get rid of Parity's toolchain. NOTE: This pull request is still draft, i.e. being updated and not ready for review (yet).
CallArgs
WIP
StateArgs
Solved with:
Unsorted
SUBSTRATE_RUNTIME_TARGET=riscv SUBSTRATE_ENABLE_POLKAVM=1 RUST_LOG=polkavm=debug cargo check -p sc-executor-polkavm