-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wasm-builder: Use riscv32emac-unknown-none-polkavm.json target #6419
base: master
Are you sure you want to change the base?
Conversation
5199aa3
to
005ec4a
Compare
How do I pass |
283e8b0
to
5205e58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just asking for a little bit of refactoring.
Co-authored-by: Alexander Theißen <[email protected]>
Signed-off-by: Jarkko Sakkinen <[email protected]>
Signed-off-by: Jarkko Sakkinen <[email protected]>
@koute possible to approve this? |
Review required! Latest push from author must always be reviewed |
substrate/utils/wasm-builder/riscv32emac-unknown-none-polkavm.json
Outdated
Show resolved
Hide resolved
Signed-off-by: Jarkko Sakkinen <[email protected]>
Signed-off-by: Jarkko Sakkinen <[email protected]>
Hmm...I might not fully understand what ur saying. I.e. I have branch in my fork and I opened PR. Isn't this the normal procedure. Please fix my process and I will follow anything i.e. not challenging status quo ;- |
I fixup that error causing 51 tests in total to fail. My bad caused by my afternoon changes.. |
What I am saying is: Don't use a fork. You can create a branch directly on this repository since you are part of the Parity organization. |
OK got it. I'll use that process in future PR's. |
Signed-off-by: Jarkko Sakkinen <[email protected]>
OK I fixed the assert and now it is giving that same 5 errors as it has been two'ish weeks :-) |
…v32emac Signed-off-by: Jarkko Sakkinen <[email protected]>
Description
Closes #6335.
Integration
N/A
Review Notes
RuntimeTarget
is converted to return path to the custom target JSON file