Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm-builder: Use riscv32emac-unknown-none-polkavm.json target #6419

Open
wants to merge 29 commits into
base: master
Choose a base branch
from

Conversation

jarkkojs
Copy link

@jarkkojs jarkkojs commented Nov 9, 2024

Description

Closes #6335.

Integration

N/A

Review Notes

RuntimeTarget is converted to return path to the custom target JSON file

@jarkkojs jarkkojs requested a review from koute as a code owner November 9, 2024 01:34
@jarkkojs jarkkojs requested a review from athei November 9, 2024 01:36
@jarkkojs jarkkojs force-pushed the wasm-builder-riscv32emac branch 22 times, most recently from 5199aa3 to 005ec4a Compare November 9, 2024 07:09
@jarkkojs
Copy link
Author

jarkkojs commented Nov 9, 2024

How do I pass check-labels?

@jarkkojs jarkkojs force-pushed the wasm-builder-riscv32emac branch 5 times, most recently from 283e8b0 to 5205e58 Compare November 9, 2024 12:08
Copy link
Member

@athei athei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just asking for a little bit of refactoring.

substrate/utils/wasm-builder/src/lib.rs Outdated Show resolved Hide resolved
substrate/utils/wasm-builder/src/wasm_project.rs Outdated Show resolved Hide resolved
@jarkkojs jarkkojs requested a review from athei November 22, 2024 14:37
@jarkkojs
Copy link
Author

@koute possible to approve this?

@github-actions github-actions bot requested a review from athei November 25, 2024 08:39
Copy link

Review required! Latest push from author must always be reviewed

@jarkkojs
Copy link
Author

Review required! Latest push from author must always be reviewed

@athei @koute was just a merge

@athei
Copy link
Member

athei commented Nov 25, 2024

Review required! Latest push from author must always be reviewed

@athei @koute was just a merge

This is because you opened the PR from your fork AFAIK. Create a branch on this repo to avoid this.

@jarkkojs
Copy link
Author

Review required! Latest push from author must always be reviewed

@athei @koute was just a merge

This is because you opened the PR from your fork AFAIK. Create a branch on this repo to avoid this.

Hmm...I might not fully understand what ur saying. I.e. I have branch in my fork and I opened PR. Isn't this the normal procedure.

Please fix my process and I will follow anything i.e. not challenging status quo ;-

@jarkkojs jarkkojs requested a review from koute November 25, 2024 18:50
@jarkkojs
Copy link
Author

I fixup that error causing 51 tests in total to fail. My bad caused by my afternoon changes..

@athei
Copy link
Member

athei commented Nov 25, 2024

Review required! Latest push from author must always be reviewed

@athei @koute was just a merge

This is because you opened the PR from your fork AFAIK. Create a branch on this repo to avoid this.

Hmm...I might not fully understand what ur saying. I.e. I have branch in my fork and I opened PR. Isn't this the normal procedure.

Please fix my process and I will follow anything i.e. not challenging status quo ;-

What I am saying is: Don't use a fork. You can create a branch directly on this repository since you are part of the Parity organization.

@jarkkojs
Copy link
Author

Review required! Latest push from author must always be reviewed

@athei @koute was just a merge

This is because you opened the PR from your fork AFAIK. Create a branch on this repo to avoid this.

Hmm...I might not fully understand what ur saying. I.e. I have branch in my fork and I opened PR. Isn't this the normal procedure.
Please fix my process and I will follow anything i.e. not challenging status quo ;-

What I am saying is: Don't use a fork. You can create a branch directly on this repository since you are part of the Parity organization.

OK got it. I'll use that process in future PR's.

@jarkkojs
Copy link
Author

Review required! Latest push from author must always be reviewed

@athei @koute was just a merge

This is because you opened the PR from your fork AFAIK. Create a branch on this repo to avoid this.

Hmm...I might not fully understand what ur saying. I.e. I have branch in my fork and I opened PR. Isn't this the normal procedure.
Please fix my process and I will follow anything i.e. not challenging status quo ;-

What I am saying is: Don't use a fork. You can create a branch directly on this repository since you are part of the Parity organization.

OK got it. I'll use that process in future PR's.

OK I fixed the assert and now it is giving that same 5 errors as it has been two'ish weeks :-)

@jarkkojs jarkkojs requested a review from athei November 30, 2024 08:42
@jarkkojs
Copy link
Author

@athei, @koute: no other changes expect solved merge conflicts with Cargo.lock.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update polkavm to the upstream toolchain version
3 participants