-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds multi-block election types and refactors current pallets to support new interfaces and types #6034
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only looked at traits. Will do another pass.
…into gpestana/epm-mb
|
||
let (exposure_metadata, exposure_pages) = exposure.into_pages(page_size); | ||
defensive_assert!(exposure_pages.len() == expected_page_count, "unexpected page count"); | ||
if let Some(stored_overview) = ErasStakersOverview::<T>::get(era, &validator) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ank4n @kianenigma to review this one last time. I think it can be written simpler.
Does it have good tests?
pub mod v17 { | ||
use super::*; | ||
|
||
pub struct VersionedMigrateV16ToV17<T>(core::marker::PhantomData<T>); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: test for this.
bot bench substrate-pallet --pallet=pallet_staking |
@kianenigma https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/8044020 was started for your command Comment |
@kianenigma Command |
Co-authored-by: Ankan <[email protected]>
/cmd bench --pallet pallet_staking |
Command "bench --pallet pallet_staking" has started 🚀 See logs here |
Command "bench --pallet pallet_staking" has failed ❌! See logs here |
/cmd bench --pallet pallet_staking |
Command "bench --pallet pallet_staking" has started 🚀 See logs here |
All GitHub workflows were cancelled due to failure one of the required jobs. |
Command "bench --pallet pallet_staking" has failed ❌! See logs here Command output:❌ Failed benchmarks of runtimes/pallets: |
This PR refactors the types and structs required to run a mulit-block election and updates the EPM, staking-pallet and all dependent pallets to use the multi-block types. The Westend runtime is configured to run a 1 paged election, which is a noop refactor compared to the current single-block election.
Notable changes since last reviews:
Tasks based on feedback that can be closed after merging this PR: Umbrella ticket for multi-block election tasks to improve after PR#6034.
The multi-block election provider pallet is wip and it's added in a separate PR (#6213).
To-do before merging:
on_intialize
in pallet staking