Skip to content

Commit

Permalink
Update prdoc/pr_6643.prdoc
Browse files Browse the repository at this point in the history
Co-authored-by: Adrian Catangiu <[email protected]>
  • Loading branch information
franciscoaguirre and acatangiu authored Nov 29, 2024
1 parent 9ced35f commit 7d777cf
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion prdoc/pr_6643.prdoc
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ title: Added fallback_max_weight to Transact for sending messages to V4 chains
doc:
- audience: Runtime Dev
description: |-
Removing the `require_weight_at_most` parameter in V5 Transact had only one problem. Converting a message from V5 to V4 to send to chains that didn't upgrade yet. The conversion would not know what weight to give to the Transact, since V4 and below require it.
Removing the `require_weight_at_most` parameter in V5 Transact introduced a problem when converting a message from V5 to V4 to send to chains that didn't upgrade yet. The local chain doesn't know how to decode call for remote chain so it can't automatically populate `require_weight_at_most` required by V4 Transact.

To fix this, I added back the weight in the form of an `Option<Weight>` called `fallback_max_weight`. This can be set to `None` if you don't intend to deal with a chain that hasn't upgraded yet. If you set it to `Some(_)`, the behaviour is the same. The plan is to totally remove this in V6 since there will be a good conversion path from V6 to V5.
crates:
Expand Down

0 comments on commit 7d777cf

Please sign in to comment.