Make relayer_reward_per_message field an option #2632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serban300
approved these changes
Oct 19, 2023
bkontur
pushed a commit
that referenced
this pull request
May 7, 2024
* relayer_reward_per_message is now Option<RelayerRewardAtSource> * fixed benchmarks compilation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #2486
extracted from #2605
follow up for #2613
In #2613 I've missed the fact that unregistered relayers may still deliver messages. We still need to reward such relayers, but how to fill the
relayer_reward_per_messagethen? Unregistered relayer can't specify this value. We could use some special value (u64::MAX) for such entries or we could useOption<u64>. 1-byte overhead looks not that large, so probably it is fine to useOption<u64>, because it is looks more natural.I'm also thinking of replacing all
u64in messages runtime storage withCompact<u64>, it shall make values even smaller.