Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Symlink chain-specs json files to crate where they are used #2979

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Morganamilo
Copy link
Contributor

When publishing crates, each crate becomes it's own tarball that can't access files from other crates. So symlink the files to be crate local and cargo will replace the symlinks with real files at publish time.

When publishing crates, each crate becomes it's own tarball that can't
access files from other crates. So symlink the files to be crate local
and cargo will replace the symlinks with real files at publish time.
@Morganamilo Morganamilo added B0-silent Changes should not be mentioned in any release notes T9-release This PR/Issue is related to topics touching the release notes. A0-please_review Pull request needs code review. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. labels Aug 7, 2023
@bkchr
Copy link
Member

bkchr commented Aug 14, 2023

We should just move the chain-specs directory directly. No need to have it symlinked.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. T9-release This PR/Issue is related to topics touching the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants