Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential github action smells #9672

Open
wants to merge 2 commits into
base: v2
Choose a base branch
from
Open

Fix potential github action smells #9672

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad92827
Fix gha smells
ceddy4395 Apr 18, 2024
54ea606
Fix typo in paths for canary-release and ci
ceddy4395 May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 20 additions & 0 deletions .github/workflows/canary-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,26 @@ on:
push:
branches:
- v2
paths:
- yarn.lock
- verdaccioPublish.js
- verdaccio.yml
- rustfmt.toml
- rust-toolchain
- README.md
- package.json
- lerna.json
- gulpfile.js
- Cargo.toml
- Cargo.lock
- babel.config.json
- sciprts/**
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be scripts?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, typo on my side, appologies! I've also fixed this in ci.yml.

- patches/**
- packages/**
- flow-typed/**
- flow-libs/**
- docs/**
- crates/**
workflow_dispatch:

jobs:
Expand Down
24 changes: 24 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,34 @@ on:
push:
branches:
- v2
paths:
- yarn.lock
- verdaccioPublish.js
- verdaccio.yml
- rustfmt.toml
- rust-toolchain
- README.md
- package.json
- lerna.json
- gulpfile.js
- Cargo.toml
- Cargo.lock
- babel.config.json
- sciprts/**
- patches/**
- packages/**
- flow-typed/**
- flow-libs/**
- docs/**
- crates/**

permissions:
contents: read

concurrency:
group: ${{ github.workflow }} - ${{ github.ref }}
cancel-in-progress: true

jobs:
lint:
name: Lint
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ jobs:
run: strip -x packages/*/*/*.node # Must use -x on macOS. This produces larger results on linux.
- name: Upload artifacts
uses: actions/upload-artifact@v3
if: ${{github.repository == 'parcel-bundler/parcel' && success()}}
with:
name: bindings-${{ matrix.name }}
path: packages/*/*/*.node
Expand Down