-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suspend incomplete requests #9636
Open
benjervis
wants to merge
8
commits into
v2
Choose a base branch
from
fix-dev-dep-requests
base: v2
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+92
−2
Open
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
fd4a4c1
Add a feature flag for the devdep fix
benjervis 074ae29
Add some proper messages to the devdep nullthrows
benjervis db1ecfd
Suspend incomplete requests
benjervis 947f94a
Rename property to align with cache
benjervis 0b614e9
Add some logging
benjervis b2a31f8
Fix flow errors
mattcompiles da3b8a1
Merge branch 'v2' into fix-dev-dep-requests
mattcompiles 26b48e9
Remove some `.only`s from tests
benjervis File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -190,14 +190,22 @@ export async function runDevDepRequest<TResult>( | |
await api.runRequest<null, DevDepRequestResult | void>({ | ||
id: 'dev_dep_request:' + devDepRequest.specifier + ':' + devDepRequest.hash, | ||
type: requestTypes.dev_dep_request, | ||
incompleteRequest: !( | ||
devDepRequest.invalidateOnFileChange && | ||
devDepRequest.invalidateOnFileCreate | ||
), | ||
run: ({api}) => { | ||
for (let filePath of nullthrows(devDepRequest.invalidateOnFileChange)) { | ||
for (let filePath of nullthrows( | ||
devDepRequest.invalidateOnFileChange, | ||
'DevDepRequest missing invalidateOnFileChange', | ||
)) { | ||
api.invalidateOnFileUpdate(filePath); | ||
api.invalidateOnFileDelete(filePath); | ||
} | ||
|
||
for (let invalidation of nullthrows( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should probably look at adding a lint rule to ensure There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could just change the type definition. It'd be a bit of work though 😅 |
||
devDepRequest.invalidateOnFileCreate, | ||
'DevDepRequest missing invalidateOnFileCreate', | ||
)) { | ||
api.invalidateOnFileCreate(invalidation); | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have
RequestGraph#incompleteNodeIds
and alsoincompleteNodePromises
. Could you use those here?