Remove src to lib rewrites on package.json files #9612
Merged
+90
−48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit modifies the strategy to local src/lib rewrites, so that the package.json files are never modified.
Intead, the package.json files always point at
bin/...
; which in turn requireslib/bin.js
.During development,
lib/bin.js
can just requiresrc/bin.js
and rely on require.extensions register. But on distributionlib/**
can be pre-built.By maintaining a stable
bin/...
entry-point, the following benefits are achieved:node_modules/.bin/parcel
points at a non existantlib/
file, which can only be fixed by removing node_modules and yarn installing again✔️ PR Todo