Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unwinder/native: Per mapping unwinder switching (including runtime unwinders) #2625

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kakkoyun
Copy link
Member

@kakkoyun kakkoyun commented Mar 18, 2024

Signed-off-by: Kemal Akkoyun [email protected]

TBD

There are still a couple of more things that I'd like to add.

@gnurizen
Copy link
Contributor

Is there a discussion somewhere of what this is fixing? For the record I think mixing non-functional cosmetic changes with functional changes is bad practice and just makes things harder on reviewers.

@kakkoyun
Copy link
Member Author

Is there a discussion somewhere of what this is fixing? For the record I think mixing non-functional cosmetic changes with functional changes is bad practice and just makes things harder on reviewers.

"Cosmetic" changes are my attempt to make the code easy to reason about myself. It started as finding some bugs in the JIT unwinding phase. And then I realized some things that we might need to do better. This requires a lot of tests (which I plan to add). I would be happy to split the PR into easy-to-ingest smaller PRs, but first, I need to finish and ensure the behavior I intended works as expected.

However, since I don't work on the project full-time anymore, the progress will come slower. I'd be happy to discuss my intentions online during office hours, and we can come up with a plan together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants