Add check for Arm64 DWARF Expressions #2452
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebase on latest, updated testdata repo |
DWARF Expressions are encoded with a `DW_CFA_def_cfa_expression` or `DW_CFA_expression` (as per aarch64 DWARF ABI). However grepping for either in `.eh_frame` debug information did not show any results (including hardcoded PLT patter heuristics) unlike in x86. (See #1058 for the x86 implementation). Tested on system binaries and libc in multiple distros: Debian, Fedora, Centos, Ubuntu Workflow: ``` `docker run -it --network=host arm64v8/fedora bash` `docker cp 0693985d3bba:/ ./fedrepo` `sudo readelf -wf ./fedrepo/bin/* 2>/dev/null | grep DW_CFA_cfa_def_expression` `sudo readelf -wF ./centos-repo/bin/* 2>/dev/null | grep exp` ``` Return an error for now if we come across an expression in Arm64 binaries. Signed-off-by: Sumera Priyadarsini <[email protected]>
Sylfrena
force-pushed
the
arm-plt-panic
branch
from
ea4c062
to
764a0de
Compare
|
What's left so that this is still WIP? |
|
So sorry, didn't see your question earlier. I want to rebase this branch on latest testdata changes but haven't gotten to thoroughly check all the new uploaded binaries. |
Sylfrena
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan