Skip to content
This repository has been archived by the owner on Jul 23, 2018. It is now read-only.

Update the plugin to use cleaner and shinier icons. #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sus007
Copy link

@sus007 sus007 commented May 31, 2018

The old icon was quite boring, so I decided to steal a nicer logo/icon for the plugin.

Old Old2

New Icon New2

Sleek & Transparent too

@sus007 sus007 changed the title Updated the plugin to use a cleaner and shinier icons. Updated the plugin to use cleaner and shinier icons. May 31, 2018
@sus007 sus007 changed the title Updated the plugin to use cleaner and shinier icons. Update the plugin to use cleaner and shinier icons. May 31, 2018
@drammock
Copy link

drammock commented May 31, 2018

You can't just re-use the logo of a piece of commercial software without permission. Before even considering merging this in, demonstrate that you have permission to re-use that logo. This raises another issue: this repo should probably add a license file (potentially with different licenses for code and artwork).

Licensing issues aside, personally I'm 👎 on this PR: I don't love the old logo, but I don't think the proposed replacement is an improvement.

@sus007
Copy link
Author

sus007 commented Jun 1, 2018

@drammock I can understand your concerns regarding the unethical use of another commercial software's logo/icon. But, let me remind you that the original logo was also a stolen logo, nonetheless. Plus, it's not like this software/plugin is trending in XFCE's Official Plugin/App Store, it's merely consumed by couple hundreds of us, so that shouldn't worry us alot. It's on you, whether you want to have this new logo on your XFCE Panel or not.

@drammock
Copy link

drammock commented Jun 1, 2018

I didn't know that the image's use in the commercial app was "stolen", but that is irrelevant. Like it or not, incorporating non-free material into free software opens up the developer to lawsuits, and is a violation of GitHub's terms of service. The fact that a lawsuit may be unlikely in this particular case because this program is not "trending" does not mean that the developer's GitHub account is magically immune from being terminated for such violations.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants