fix(make): use the default rust dir for build/build-op

[jsvisa]

Currently, we use cargo build --target $(shell rustc -Vv | grep host | cut -d ' ' -f2) to run the make build process, this will put the result into the directory as below:

target/aarch64-apple-darwin/release/reth # for macOS
target/x86_64-unknown-linux-gnu/release/reth # for Linux

This is inconvenience to run reth command(eg: ./target/aarch64-apple-darwin/release/reth node --dev), so propose to use the default rust target directory(target/{release,debug}) for the build process.

[mattsse]

yeah no idea why we do this

am I missing anything @onbjerg @shekhirin ?

[onbjerg]

we use this for the cross-platform docker builds which requires a very specific structure (target/$platform/$profile), so we cannot accommodate this

[mattsse]

maybe we could rename this to docker-build instead and add these changes as build?

I can see how make build would be inconvenient here

[jsvisa]

we use this for the cross-platform docker builds which requires a very specific structure (target/$platform/$profile), so we cannot accommodate this

@onbjerg Seems docker build not using the build target:

reth/Makefile

Lines 218 to 233 in 8dbffee

	define docker_build_push
	$(MAKE) build-x86_64-unknown-linux-gnu
	mkdir -p $(BIN_DIR)/amd64
	cp $(BUILD_PATH)/x86_64-unknown-linux-gnu/$(PROFILE)/reth $(BIN_DIR)/amd64/reth
	$(MAKE) build-aarch64-unknown-linux-gnu
	mkdir -p $(BIN_DIR)/arm64
	cp $(BUILD_PATH)/aarch64-unknown-linux-gnu/$(PROFILE)/reth $(BIN_DIR)/arm64/reth
	docker buildx build --file ./Dockerfile.cross . \
	--platform linux/amd64,linux/arm64 \
	--tag $(DOCKER_IMAGE_NAME):$(1) \
	--tag $(DOCKER_IMAGE_NAME):$(2) \
	--provenance=false \
	--push
	endef

which uses build-% instead(not this pr related build)

reth/Makefile

Lines 102 to 105 in 8dbffee

	build-%:
	RUSTFLAGS="-C link-arg=-lgcc -Clink-arg=-static-libgcc" \
	cross build --bin reth --target $* --features "$(FEATURES)" --profile "$(PROFILE)"

[onbjerg]

I don't think renaming this to docker-build makes sense either as that would imply building the docker image, build-%i is to build for a specific platform without overriding the binary each time. I see that this pr is just for build, so maybe this is ok.