fix: only run windows check on windows runner #13937
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rjected
added
C-bug
Rjected
force-pushed
the
dan/only-run-windows-check-on-windows-runner
branch
from
027096f to
6181fc0
Compare
Rjected
force-pushed
the
dan/only-run-windows-check-on-windows-runner
branch
from
6181fc0 to
90692e6
Compare
Rjected
force-pushed
the
dan/only-run-windows-check-on-windows-runner
branch
from
90692e6 to
a0e0457
Compare
|
sounds like a bug in crunchy the cfg'ing done on out_dir looks unnecessary |
Yeah, have not figured out why it's doing that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only runs the windows check on windows runners, because
crunchy 0.2.3(transitive dep fromtiny-keccaknow relies on the host path separator being the same as the target path separator.