Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft(optimism): sendRawTransactionConditional #13926

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hamdiallam
Copy link

@hamdiallam hamdiallam commented Jan 22, 2025

Leaving a few comments in the different places that might require changes. Will flesh out an implementation after a soft approval/guidance in the right direction

  1. OpTransactionSigned / OpPooledTransaction. References to conditional and notion of rejected

    • The builder interfaces with OpTransactionSigned. We need reference to the conditional to validate during execute_best_transactions and a means to invalidate from the pool.
  2. L2EthApiExt & OpTransactionSigned: Can the conditional be attached as an optional field on the deserialized tx? This way pool::add_transaction is simply used. Or should a pool wrapper have a separate interface for submission.

  3. PoolWrapper -> If we wrap the Pool interface, should this filter out the rejected txs and in a background task remove them from the pool?

    • We could implement the validation logic in validate_one which would duplicate the conditional checks

@emhane emhane added A-block-building Related to block building A-tx-pool Related to the transaction mempool A-op-reth Related to Optimism and op-reth labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-block-building Related to block building A-op-reth Related to Optimism and op-reth A-tx-pool Related to the transaction mempool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants