draft(optimism): sendRawTransactionConditional #13926
Draft
+104
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leaving a few comments in the different places that might require changes. Will flesh out an implementation after a soft approval/guidance in the right direction
OpTransactionSigned
/OpPooledTransaction
. References toconditional
and notion ofrejected
OpTransactionSigned
. We need reference to the conditional to validate duringexecute_best_transactions
and a means to invalidate from the pool.L2EthApiExt
&OpTransactionSigned
: Can the conditional be attached as an optional field on the deserialized tx? This waypool::add_transaction
is simply used. Or should a pool wrapper have a separate interface for submission.PoolWrapper -> If we wrap the
Pool
interface, should this filter out the rejected txs and in a background task remove them from the pool?validate_one
which would duplicate the conditional checks