Fixes problems with the demo and an annoying warning #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itay-grudev
commented
May 27, 2016
itay-grudev
commented
warning: field 'm_multiplier' will be initialized after field 'm_dpi' [-Wreorder] : QObject(attachee), m_screen(nullptr), m_window(nullptr), m_multiplier(1), m_dpi(0)
As the file was listed in the demo.qrc it caused an error on compilation.
The Material module was not included in the demo nor were any import paths present.
itay-grudev
changed the title
|
The last two commits fix problems with the demo. A missing icon causing a compilation error and a fix to the missing Material module when not installed in the system path by including the The definition of QPM_INIT is mandatory as to force the registration of the Then you can have a condition that would force it's definition in the #ifdef QPM_INIT
#define QML_METERIAL_REGISTER
#endif |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.