Info Alerts are Signals #1327
Draft
Info Alerts are Signals #1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
😱 [INFO][root]: ignoring file dependabot.yml |
ben-githubs
requested changes
Aug 20, 2024
There was a problem hiding this comment.
The following rules have been set to CreateAlert: false, but their Python files have dynamic severity functions that could return severities other than "INFO". We should remove CreateAlert: false for these rules.
- rules/push_security_rules/push_security_mfa_method_changed.yml
- rules/push_security_rules/push_security_phishable_mfa_method.yml
- rules/github_rules/github_repo_hook_modified.yml
- rules/gsuite_activityevent_rules/gsuite_passthrough_rule.yml
- rules/okta_rules/okta_admin_role_assigned.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Info severity alerts are auto-closed and primarily used as signal generators for correlation rules. This change stores matches in the Signals table for correlations, while keeping them off the alert interface.
Changes
Testing