Prefer require_relative for internal requires #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`require_relative` is preferred over `require` for files within the same project because it uses paths relative to the current file, making code more portable and less dependent on the load path. This change updates internal requires to use `require_relative` for consistency, performance, and improved portability. Ref: - ruby/psych#522 - ruby/logger#20 - ruby/rdoc#658 - panorama-ed#349 - rubocop/rubocop#8748
tagliala
force-pushed
the
chore/prefer-require-relative
branch
from
e814665
to
40cb797
Compare
tagliala
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #350 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 190 190
Branches 90 90
=========================================
Hits 190 190 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a side note, this change has been approved here by
@deivid-rodriguezwhich is familiar with this issue: activeadmin/arbre#622require_relativeis preferred overrequirefor files within the sameproject because it uses paths relative to the current file, making code
more portable and less dependent on the load path.
This change updates internal requires to use
require_relativeforconsistency, performance, and improved portability.
Ref:
require_relativefor internal requires ruby/psych#522require_relativerubocop/rubocop#8748Before merging:
Copy the table printed at the end of the latest benchmark results into theREADME.mdand update this PRIf this change merits an update toCHANGELOG.md, add an entry following Keep a Changelog guidelines with semantic versioning