GH1045 Split overload of groupby on as_index for all cases #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dr-Irv
requested changes
Nov 21, 2024
| ), | ||
| pd.Series, | ||
| ) | ||
|
|
There was a problem hiding this comment.
can you add a test that doesn't include the as_index argument?
There was a problem hiding this comment.
Sorry the issue wasn't there, I did a bad copy paste so it was the same test.
Now the tests are different. which includes the test case from the issue.
As well I have added a third case in both tests where we don't specify as_index as you mentioned above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
groupby.size()don't work for all possible groupby #1045assert_type()to assert the type of any return value