Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] refactor: Use isTimeoutEnabled constant in other parts of <Toast2> #6785

Merged
merged 1 commit into from May 13, 2024
Merged

[core] refactor: Use isTimeoutEnabled constant in other parts of <Toast2> #6785

merged 1 commit into from May 13, 2024

Conversation

gluxon
Copy link
Contributor

@gluxon gluxon commented May 3, 2024 •
edited

Optional change on top of #6783. This should be a no-op.

@gluxon gluxon force-pushed the bcheng/toast2-reuse-constant branch from 02d078a to 67dd861 Compare May 3, 2024 03:49
@gluxon gluxon marked this pull request as ready for review May 3, 2024 03:50
@gluxon gluxon requested review from ericjeney and pgoldberg May 3, 2024 03:50
@svc-palantir-github
Copy link

Use isTimeoutEnabled constant in other parts of

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

pgoldberg
pgoldberg previously approved these changes May 3, 2024
View reviewed changes
Base automatically changed from bcheng/fix-toast-dismiss-on-mouseleave to develop May 3, 2024 18:23
@gluxon gluxon force-pushed the bcheng/toast2-reuse-constant branch from 67dd861 to 4e67b18 Compare May 3, 2024 20:14
@policy-bot policy-bot bot dismissed pgoldberg’s stale review May 3, 2024 20:14

Invalidated by push of 4e67b18

@gluxon gluxon enabled auto-merge (squash) May 3, 2024 20:15
@gluxon gluxon force-pushed the bcheng/toast2-reuse-constant branch from 4e67b18 to 8cb0f48 Compare May 3, 2024 21:19
@svc-palantir-github
Copy link

Use isTimeoutEnabled constant in other parts of

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

pgoldberg
pgoldberg approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@pgoldberg pgoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed my approval was invalidated!

@gluxon gluxon merged commit 906f5d0 into develop May 13, 2024
13 checks passed
@gluxon gluxon deleted the bcheng/toast2-reuse-constant branch May 13, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgoldberg pgoldberg pgoldberg approved these changes

@ericjeney ericjeney Awaiting requested review from ericjeney

Assignees
No one assigned
Labels
no changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gluxon @svc-palantir-github @pgoldberg