Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DateRangeInput3 closing on time change in Examples #6782

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

moon1ock
Copy link
Member

@moon1ock moon1ock commented May 2, 2024

this.props.timePrecision which is supposed to be an alias for this.props.timePickerProps.precision seems to be never set and is always null.

I tried going down the rabbit hole to figure out how to update it properly, but it's just a can of worms.
Contributing a solution to the docs: it's not elegant, but it works

@changelog-app
Copy link

changelog-app bot commented May 2, 2024

Generate changelog in packages/datetime2/changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Fix DateRangeInput3 closing on time change

Check the box to generate changelog(s)

  • Generate changelog entry

@palantir palantir deleted a comment from svc-palantir-github May 2, 2024
@moon1ock moon1ock changed the title Fix DateRangeInput3 closing on time change Fix DateRangeInput3 closing on time change in Examples May 2, 2024
@svc-palantir-github
Copy link

but i ran prettier... and yarn lint-fix... and yarn format

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

Copy link
Contributor

@ericjeney ericjeney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this and digging in to where the bug is, @moon1ock!

I don't think we should merge this docs change, though. I'd like the docs to continue to represent the "good" / expected ways that people should use components, rather than make it seem like this bug is an expected part of our API.

I recognize that's not a very satisfying answer since we haven't fixed the bug itself yet, but I'm glad you found a workaround that should work for you in your codebase at least. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants