WARNING: Pact file has no interactions

[tienvx]

How to reproduce this issue:

• git clone --branch bug-pact-file-no-interactions [email protected]:tienvx/pact-php.git
• cd pact-php/example/matchers/consumer
• phpunit
• cd ../provider
• phpunit

This issue only happen with 0.4.12. It doesn't happen with 0.4.11

Here is the commit that can explain what happen:

diff --git a/composer.json b/composer.json
index c83557c9..7db191e6 100644
--- a/composer.json
+++ b/composer.json
@@ -103,12 +103,12 @@
     "extra": {
         "downloads": {
             "pact-ffi-headers": {
-                "version": "0.4.11",
+                "version": "0.4.12",
                 "url": "https://github.com/pact-foundation/pact-reference/releases/download/libpact_ffi-v{$version}/pact.h",
                 "path": "bin/pact-ffi-headers/pact.h"
             },
             "pact-ffi-lib": {
-                "version": "0.4.11",
+                "version": "0.4.12",
                 "variables": {
                     "{$prefix}": "PHP_OS_FAMILY === 'Windows' ? 'pact_ffi' : 'libpact_ffi'",
                     "{$os}": "PHP_OS === 'Darwin' ? 'osx' : strtolower(PHP_OS_FAMILY)",
diff --git a/example/matchers/pacts/matchersConsumer-matchersProvider.json b/example/matchers/pacts/matchersConsumer-matchersProvider.json
index a9f8dce8..c2686643 100644
--- a/example/matchers/pacts/matchersConsumer-matchersProvider.json
+++ b/example/matchers/pacts/matchersConsumer-matchersProvider.json
@@ -29,21 +29,21 @@
             ]
           },
           "query": {
-            "$.pages": {
+            "locales[]": {
               "combine": "AND",
               "matchers": [
                 {
                   "match": "regex",
-                  "regex": "\\d+"
+                  "regex": "^[a-z]{2}-[A-Z]{2}$"
                 }
               ]
             },
-            "$['locales[]']": {
+            "pages": {
               "combine": "AND",
               "matchers": [
                 {
                   "match": "regex",
-                  "regex": "^[a-z]{2}-[A-Z]{2}$"
+                  "regex": "\\d+"
                 }
               ]
             }
@@ -591,9 +591,9 @@
   ],
   "metadata": {
     "pactRust": {
-      "ffi": "0.4.11",
+      "ffi": "0.4.12",
       "mockserver": "1.2.4",
-      "models": "1.1.12"
+      "models": "1.1.14"
     },
     "pactSpecification": {
       "version": "4.0"

[rholshausen]

Hmm, this is odd. Let me check the commit history to see what could be causing this.

[tienvx]

I think locales[] in the pact file causing this issue.

This query syntax locales[]=first&locales[]=second (PHP is using this syntax as multiple values) is mapped to "$['locales[]']": {"matchers": ...} in pact file in 0.4.11 and it's supported, now it's mapped to "locales[]": {"matchers": ...} and look like it's not supported any more -> result in the 'warning' above

[rholshausen]

But that should never result in the interaction being ignored and an empty Pact returned. It should either ignore just that matching rule and load the result or return an error for the whole process.

I think it is something else going wrong. I'm debugging it now.

[rholshausen]

Ok, got it failing correctly now (it was ignoring any error when loading the interaction).

Failures:

1) Failed to load pact - Failed to load pact '/home/ronald/Development/Pact/pact-php/example/matchers/provider/tests/../../pacts/matchersConsumer-matchersProvider.json' - Empty bracket expressions are not allowed in path expression "locales[]" at index 8


There were 1 pact failures

[rholshausen]

Now to fix that issue

[rholshausen]

0.4.13 works for me

[tienvx]

It works for me too. But I got another issue. Probably it's not related, so I will close this issue and create another issue for it.

EDITED: Here is the issue anyway:

1. Failed to load pact - Failed to load pact '/home/tien/Projects/pact/pact-php/compatibility-suite/tests/Constant/../../pacts/c-p.json' - Matching rule JSON [] is not correctly formed

[tienvx]

Created another issue for it #360

Thank you for fixing this one. Closing.