fix: Error where interactions failed to load where being silently ign…

…ored #359

rust/pact_models/src/v4/interaction.rs

@@ -182,15 +182,16 @@ impl PartialEq for Box<dyn V4Interaction + Send + Sync + RefUnwindSafe> {
 }
 
 /// Load V4 format interactions from JSON struct
-pub fn interactions_from_json(json: &Value, source: &str) -> Vec<Box<dyn V4Interaction + Send + Sync + RefUnwindSafe>> {
+pub fn interactions_from_json(json: &Value, source: &str) -> anyhow::Result<Vec<Box<dyn V4Interaction + Send + Sync + RefUnwindSafe>>> {
   match json.get("interactions") {
     Some(Value::Array(ref array)) => {
-      array.iter().enumerate().map(|(index, ijson)| {
-        interaction_from_json(source, index, ijson).ok()
-      }).flatten()
-        .collect()
+      let mut interactions = vec![];
+      for (index, ijson) in array.iter().enumerate() {
+        interactions.push(interaction_from_json(source, index, ijson)?);
+      }
+      Ok(interactions)
     },
-    _ => vec![]
+    _ => Ok(vec![])
   }
 }
 

rust/pact_models/src/v4/pact.rs

@@ -158,7 +158,7 @@ impl V4Pact {
     Ok(V4Pact {
       consumer,
       provider,
-      interactions: interactions_from_json(&json, source),
+      interactions: interactions_from_json(&json, source)?,
       metadata,
       plugin_data
     })
@@ -447,7 +447,7 @@ pub fn from_json(source: &str, pact_json: &Value) -> anyhow::Result<Box<dyn Pact
   Ok(Box::new(V4Pact {
     consumer,
     provider,
-    interactions: interactions_from_json(pact_json, source),
+    interactions: interactions_from_json(pact_json, source)?,
     metadata,
     plugin_data
   }))