Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade libraries and fix tests #1337

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

mefellows
Copy link
Member

@mefellows mefellows commented Jan 9, 2025

  • npm run dist works locally (this will run tests, lint and build)
  • Commit messages are ready to go in the changelog (see below for details)
  • PR template filled in (see below for details)

PR Template

This change updates to the latest TypeScript and fixes the remaining broken tests from recent dependabot and workflow changes.

@mefellows mefellows force-pushed the chore/upgrade-libraries_typescript-chai branch 2 times, most recently from db621e5 to d99a5f4 Compare January 9, 2025 12:51
@mefellows
Copy link
Member Author

@JP-Ellis FYI have progressed a number of the issues in the rewrite. Looks like we're down to the examples now (see https://github.com/pact-foundation/pact-js/actions/runs/12690437753/job/35371328939)..

I suspect the error relates to the dist folder copy/pasting although that's just a guess. I've run out of time this week (off on leave tomorrow) but thought I'd give you the heads up on this change.

I can revisit next week.

@mefellows mefellows changed the title Chore/upgrade libraries typescript chai Upgrade libraries and fix tests Jan 9, 2025
@JP-Ellis
Copy link
Contributor

JP-Ellis commented Jan 10, 2025

Good news (?), I'm able to replicate the issue:

For some reason, deleting the root node_modules replicates the issue. That is:

  1. Run npm run dist (having run npm ci already)
  2. Remove the root node_modules
  3. cd into one of the examples, and run npm ci && npm run test:consumer

EDIT: Based on this finding, I have 'fixed' the CI by installing dependencies to the root package. This has uncovered just one final failure.

@JP-Ellis JP-Ellis force-pushed the chore/upgrade-libraries_typescript-chai branch from 26dbefe to c87060e Compare January 10, 2025 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants