-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some fixes #2
Merged
Some fixes #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit applies code from package_control_channel/tests after dropping all python 2 related expressions.
This commit adds `Binary` and `Git Formats` to the list of default packages.
1. sort urls alphabetically 2. reformat patterns to use more of available space 3. disallow `#` (start of anchors) and `?` (start of parameters) in user and repository names 4. move (?<!\.git) to ensure not to accept something like https://github.com/repo/user.git/tree/master
Now that arm64 is supported it is very valid to have both x32 and x64 to specify arm64 is not supported.
To support validation and completions via LSP-json, Package Control ships json schemas for channels and repositories. This commit allows them to be explicitly assigned without tests failing via - "$schema": "sublime://packagecontrol.io/schemas/channel", - "$schema": "sublime://packagecontrol.io/schemas/repository",
rchl
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me but didn't do any real testing.
deathaxe
force-pushed
the
develop
branch
4 times, most recently
from
November 26, 2023 10:42
6b4a6bc
to
6a3e21d
Compare
deathaxe
force-pushed
the
develop
branch
2 times, most recently
from
November 26, 2023 11:17
6151c5c
to
a579a6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically syncs with wbond/package_control_channel#8835