Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes #2

Merged
merged 10 commits into from
Nov 26, 2023
Merged

Some fixes #2

merged 10 commits into from
Nov 26, 2023

Conversation

deathaxe
Copy link
Contributor

Basically syncs with wbond/package_control_channel#8835

This commit applies code from package_control_channel/tests after dropping all
python 2 related expressions.
This commit adds `Binary` and `Git Formats` to the list of default packages.
1. sort urls alphabetically
2. reformat patterns to use more of available space
3. disallow `#` (start of anchors) and `?` (start of parameters)
   in user and repository names
4. move (?<!\.git) to ensure not to accept something like
   https://github.com/repo/user.git/tree/master
Now that arm64 is supported it is very valid to have both x32 and x64
to specify arm64 is not supported.
To support validation and completions via LSP-json, Package Control ships
json schemas for channels and repositories.

This commit allows them to be explicitly assigned without tests failing via
- "$schema": "sublime://packagecontrol.io/schemas/channel",
- "$schema": "sublime://packagecontrol.io/schemas/repository",
Copy link
Contributor

@rchl rchl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me but didn't do any real testing.

@deathaxe deathaxe force-pushed the develop branch 4 times, most recently from 6b4a6bc to 6a3e21d Compare November 26, 2023 10:42
@deathaxe deathaxe force-pushed the develop branch 2 times, most recently from 6151c5c to a579a6e Compare November 26, 2023 11:17
@deathaxe deathaxe merged commit 5f7853b into main Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants