Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency mgechev/revive to v1.3.9 #3813

Merged
merged 4 commits into from
Aug 16, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 27, 2024

Mend Renovate

This PR contains the following updates:

Package Update Change
mgechev/revive patch v1.3.7 -> v1.3.9

Release Notes

mgechev/revive (mgechev/revive)

v1.3.9

Compare Source

Changelog

v1.3.8

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link
Contributor

github-actions bot commented Jul 27, 2024

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ API spectral 1 0 1.55s
✅ BASH bash-exec 5 0 0.02s
✅ BASH shellcheck 5 0 0.13s
✅ BASH shfmt 5 0 0 0.02s
✅ COPYPASTE jscpd yes no 3.81s
✅ DOCKERFILE hadolint 126 0 14.34s
✅ JSON jsonlint 18 0 0.21s
✅ JSON v8r 20 0 27.17s
⚠️ MARKDOWN markdownlint 263 0 267 30.82s
✅ MARKDOWN markdown-table-formatter 263 0 0 138.22s
⚠️ PYTHON bandit 208 64 3.84s
✅ PYTHON black 208 0 0 5.11s
✅ PYTHON flake8 208 0 1.69s
✅ PYTHON isort 208 0 0 0.73s
✅ PYTHON mypy 208 0 19.14s
✅ PYTHON pylint 208 0 30.21s
✅ PYTHON ruff 208 0 0 0.09s
✅ REPOSITORY checkov yes no 40.5s
✅ REPOSITORY git_diff yes no 0.02s
⚠️ REPOSITORY grype yes 1 13.79s
✅ REPOSITORY secretlint yes no 12.61s
✅ REPOSITORY trivy yes no 24.29s
✅ REPOSITORY trivy-sbom yes no 1.17s
⚠️ REPOSITORY trufflehog yes 1 13.87s
✅ SPELL cspell 683 0 11.72s
⚠️ SPELL lychee 343 7 8.12s
✅ XML xmllint 3 0 0 0.02s
✅ YAML prettier 160 0 0 4.66s
✅ YAML v8r 102 0 190.5s
✅ YAML yamllint 161 0 2.34s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@echoix
Copy link
Collaborator

echoix commented Jul 28, 2024

When ready, remember to remove the downgraded_version: true from the descriptor

@echoix
Copy link
Collaborator

echoix commented Aug 15, 2024

I think I found it: mgechev/revive#993 (comment)

@nvuillam
Copy link
Member

Good catch @echoix :)
I added go apk in the descriptor root so all go linters have it :)

@echoix
Copy link
Collaborator

echoix commented Aug 15, 2024

Good catch @echoix :)

I added go apk in the descriptor root so all go linters have it :)

Not quite, adding apk for revive wasn't enough. you need to look at the branch in my fork to add the env var. I'm not sure which one is needed though. I wanted to eliminate them, but don't have time tonight.
I wanted to make sure it isn't because of the different go image used to build that has go available at a different path than when run.

Copy link
Contributor Author

renovate bot commented Aug 15, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@echoix
Copy link
Collaborator

echoix commented Aug 16, 2024

Ok, why does adding go at the descriptor level work, but not when adding it at the linter level in addition to the Dockerfile part. It doesn't make sense with the failures I had.

@nvuillam nvuillam merged commit 8373e8e into main Aug 16, 2024
126 checks passed
@nvuillam nvuillam deleted the renovate/mgechev-revive-1.x branch August 16, 2024 04:51
@nvuillam
Copy link
Member

Ok, why does adding go at the descriptor level work, but not when adding it at the linter level in addition to the Dockerfile part. It doesn't make sense with the failures I had.

Maybe something about the order ?
Go variables setting in PATH is kind of static i think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants