Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gene is called gene_name in variants #33

Open
philipwfowler opened this issue Aug 15, 2023 · 1 comment
Open

gene is called gene_name in variants #33

philipwfowler opened this issue Aug 15, 2023 · 1 comment

Comments

@philipwfowler
Copy link
Member

Very minor (!). Rename gene_name to gene in the variants.csv so is consistent with the other tables.
JeremyWesthead added a commit that referenced this issue Aug 15, 2023
@JeremyWesthead
gene_name --> gene in variants.csv for #33
e36cffb
@JeremyWesthead
Copy link
Collaborator

Fixed for the CSV - the JSON still calls it gene_name, which I've left as is for now for 2 reasons:

  1. Changing it may break the GPAS summary JSON
  2. I'd have to spend a while fixing tests

If you think it should be changed there too, I can write a ticket for it

JeremyWesthead added a commit that referenced this issue Aug 16, 2023
@JeremyWesthead
Merge pull request #34 from oxfordmmm/fix-gene-name
971f8a2 
`gene_name` --> `gene` in variants.csv for #33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@philipwfowler @JeremyWesthead