Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

realize: rewrite suspicious append with assignment #216

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

realize: rewrite suspicious append with assignment #216

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion realize/cli_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import (

func TestRealize_Stop(t *testing.T) {
r := Realize{}
r.Projects = append(r.Schema.Projects, Project{exit: make(chan os.Signal, 1)})
r.Projects = []Project{exit: make(chan os.Signal, 1)}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually a syntax error now. You're building an slice but only have one pair of brackets. It should be:

 	r.Projects = []Project{{exit: make(chan os.Signal, 1)}}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake, thanks.
Used github UI to edit the code.

r.Stop()
_, ok := <-r.Projects[0].exit
if ok != false {
Expand Down