Make default notification setting for conversations 'mentions only'.

The current default of 'all' is very noisy, especially when restoring an account or linking a new device, which causes all instantiated conversations to start sending notifications.
oxen-io · Jan 15, 2023 · b289ce1 · b289ce1
1 parent 0794ede
commit b289ce1
Show file tree

Hide file tree

Showing 7 changed files with 8 additions and 10 deletions.
diff --git a/ts/components/leftpane/conversation-list-item/HeaderItem.tsx b/ts/components/leftpane/conversation-list-item/HeaderItem.tsx
@@ -38,15 +38,14 @@ const NotificationSettingIcon = (props: { isMessagesSection: boolean }) => {
         />
       );
     case 'mentions_only':
+    default:
       return (
         <SessionIcon
           iconType="bell"
           iconColor={'var(--conversation-tab-text-color)'}
           iconSize="small"
         />
       );
-    default:
-      return null;
   }
 };
 

diff --git a/ts/hooks/useParamSelector.ts b/ts/hooks/useParamSelector.ts
@@ -93,7 +93,7 @@ export function useHasNickname(convoId?: string) {
 
 export function useNotificationSetting(convoId?: string) {
   const convoProps = useConversationPropsById(convoId);
-  return convoProps?.currentNotificationSetting || 'all';
+  return convoProps?.currentNotificationSetting || 'mentions_only';
 }
 export function useIsPublic(convoId?: string) {
   const convoProps = useConversationPropsById(convoId);

diff --git a/ts/models/conversationAttributes.ts b/ts/models/conversationAttributes.ts
@@ -90,7 +90,7 @@ export const fillConvoAttributesWithDefaults = (
     lastMessageStatus: undefined,
     lastMessage: null,
 
-    triggerNotificationsFor: 'all', // if the settings is not set in the db, this is the default
+    triggerNotificationsFor: 'mentions_only', // if the settings is not set in the db, this is the default
 
     isTrustedForAttachmentDownload: false, // we don't trust a contact until we say so
     isPinned: false,

diff --git a/ts/node/database_utility.ts b/ts/node/database_utility.ts
@@ -145,7 +145,7 @@ export function formatRowOfConversation(row?: Record<string, any>): Conversation
   }
 
   if (!convo.triggerNotificationsFor) {
-    convo.triggerNotificationsFor = 'all';
+    convo.triggerNotificationsFor = 'mentions_only';
   }
 
   if (!convo.unreadCount) {

diff --git a/ts/node/migration/sessionMigrations.ts b/ts/node/migration/sessionMigrations.ts
@@ -729,7 +729,7 @@ function updateToSessionSchemaVersion24(currentVersion: number, db: BetterSqlite
          ALTER TABLE ${CONVERSATIONS_TABLE} ADD COLUMN avatarHash TEXT; -- only used for opengroup avatar.
          ALTER TABLE ${CONVERSATIONS_TABLE} ADD COLUMN nickname TEXT;
          ALTER TABLE ${CONVERSATIONS_TABLE} ADD COLUMN profileKey TEXT;
-         ALTER TABLE ${CONVERSATIONS_TABLE} ADD COLUMN triggerNotificationsFor TEXT DEFAULT "all";
+         ALTER TABLE ${CONVERSATIONS_TABLE} ADD COLUMN triggerNotificationsFor TEXT DEFAULT "mentions_only";
          ALTER TABLE ${CONVERSATIONS_TABLE} ADD COLUMN isTrustedForAttachmentDownload INTEGER DEFAULT "FALSE";
          ALTER TABLE ${CONVERSATIONS_TABLE} ADD COLUMN isPinned INTEGER DEFAULT "FALSE";
          ALTER TABLE ${CONVERSATIONS_TABLE} ADD COLUMN isApproved INTEGER DEFAULT "FALSE";

diff --git a/ts/state/selectors/conversations.ts b/ts/state/selectors/conversations.ts
@@ -577,12 +577,11 @@ export const getCurrentNotificationSettingText = createSelector(getSelectedConve
   switch (state.currentNotificationSetting) {
     case 'all':
       return window.i18n('notificationForConvo_all');
-    case 'mentions_only':
-      return window.i18n('notificationForConvo_mentions_only');
     case 'disabled':
       return window.i18n('notificationForConvo_disabled');
+    case 'mentions_only':
     default:
-      return window.i18n('notificationForConvo_all');
+      return window.i18n('notificationForConvo_mentions_only');
   }
 });
 

diff --git a/ts/test/session/unit/models/ConversationModels_test.ts b/ts/test/session/unit/models/ConversationModels_test.ts
@@ -163,7 +163,7 @@ describe('fillConvoAttributesWithDefaults', () => {
     it('initialize triggerNotificationsFor if not given', () => {
       expect(fillConvoAttributesWithDefaults({} as ConversationAttributes)).to.have.deep.property(
         'triggerNotificationsFor',
-        'all'
+        'mentions_only'
       );
     });