-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Git Sparse checkout to make it easier to get the local rules #64
Conversation
…d/restriction" and "recommended/correctness" etc ...
Thank you for your working on this! Although this will become quite complex, doing so is meaningful, go ahead! |
this will now print out this config: {
configs: {
recommended: { plugins: [Array], rules: [Object] },
'flat/recommended': { rules: [Object] },
'flat/eslint': { rules: [Object] },
'flat/import': { rules: [Object] },
'flat/jest': { rules: [Object] },
'flat/jsdoc': { rules: [Object] },
'flat/jsxA11y': { rules: [Object] },
'flat/nextjs': { rules: [Object] },
'flat/react': { rules: [Object] },
'flat/reactPerf': { rules: [Object] },
'flat/treeShaking': { rules: [Object] },
'flat/typescript': { rules: [Object] },
'flat/unicorn': { rules: [Object] },
'flat/pedantic': { rules: [Object] },
'flat/nursery': { rules: [Object] },
'flat/style': { rules: [Object] },
'flat/correctness': { rules: [Object] },
'flat/restriction': { rules: [Object] },
'flat/suspicious': { rules: [Object] }
}
} I think we should avoid having a non-flat for all the other ones, and instead recommend to use the non-recommended configs together with setting up the plugin manually, otherwise this list will grow. |
Yes, I agree |
vitest sometimes ails because of an upstream issue with the this line is the cause: https://github.com/istanbuljs/v8-to-istanbul/blob/master/lib/range.js#L30 so i would recommend that this coverage reporter be turned off.. other than that, this PR is now ready |
I've also fixed so that the codebase works using prettier, and formats the files in vscode when saving. if you don't like the prettier configuration, please recommend what you'd prefer (see |
Yes, we can turn off coverage. we don't need it. |
Thanks for working on this! It's amazing for |
Making these changes is a prerequisite to get the categories of each of the rules according to this request: #61 which makes sense to then create recommended configurations for the separate configs.
opening this PR is to get input on direction and if this is agreed on.