Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ignore not implemented import rules #255

Closed
wants to merge 3 commits into from
Closed

fix: ignore not implemented import rules #255

wants to merge 3 commits into from

Conversation

Sysix
Copy link
Collaborator

@Sysix Sysix commented Nov 21, 2024 •
edited
Loading

I would prefer if they are deleted in oxc project. but this works too :)

@Sysix Sysix changed the title fix ignore not implemented import rules fix: ignore not implemented import rules Nov 21, 2024
@Sysix Sysix marked this pull request as ready for review November 21, 2024 18:08
@Sysix Sysix requested a review from Boshen November 21, 2024 18:08
Boshen
Boshen reviewed Nov 22, 2024
View reviewed changes
Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nursery rules should always be omitted from this plugin. Pretend they are not implemented and don't exist.

@Sysix Sysix closed this Nov 22, 2024
@Boshen Boshen deleted the fix-ignore-not-implemented-import-rules branch November 22, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boshen Boshen Boshen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sysix @Boshen