Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): do not bump version on generate, let CI manage it #199

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

Sysix
Copy link
Collaborator

@Sysix Sysix commented Oct 26, 2024

closes #198

Reason: the generate script already bumped the version in the package file. npm version v0.10.3 did not detect a file change, so it failed.

So we let now the CI manage the package version. Also I made it clearer what happens in the CI

@Boshen Boshen merged commit 37039f9 into oxc-project:main Oct 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to make a new release
2 participants