fix: buildFromOxlintConfig react-hooks rules did not applied (#254)

oxc-project · Nov 21, 2024 · bf7f215 · bf7f215
1 parent f782b27
commit bf7f215
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/src/build-from-oxlint-config.spec.ts b/src/build-from-oxlint-config.spec.ts
@@ -318,7 +318,7 @@ describe('integration test with oxlint', () => {
     {
       categories: {
         correctness: 'warn',
-        nursery: 'off', // enable after oxc-project/oxc#7073
+        nursery: 'warn',
         pedantic: 'warn',
         perf: 'warn',
         restriction: 'warn',
@@ -341,7 +341,6 @@ describe('integration test with oxlint', () => {
         'promise',
         'jest',
         'vitest',
-        'tree_shaking',
       ],
     },
     // everything on
@@ -359,11 +358,10 @@ describe('integration test with oxlint', () => {
         'promise',
         'jest',
         'vitest',
-        'tree_shaking',
       ],
       categories: {
         correctness: 'warn',
-        nursery: 'off', // enable after oxc-project/oxc#7073
+        nursery: 'off', // ToDo: something with the import plugin
         pedantic: 'warn',
         perf: 'warn',
         restriction: 'warn',

diff --git a/src/build-from-oxlint-config.ts b/src/build-from-oxlint-config.ts
@@ -240,6 +240,12 @@ export const buildFromOxlintConfig = (
   // it is not a plugin but it is activated by default
   plugins.push('eslint');
 
+  // oxc handles "react-hooks" rules inside "react" plugin
+  // our generator split them into own plugins
+  if (plugins.includes('react')) {
+    plugins.push('react-hooks');
+  }
+
   handleCategoriesScope(
     plugins,
     readCategoriesFromConfig(config) ?? defaultCategories,